Code fix to handle Dbus failure
The commit implement changes to catch and log error instead
of re throwing a run time exception in case there is any Dbus
failure while calling phosphor-logging service.
It was required as there is no need to re throw runtime error
in that case.
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: Ic62ee3d37e6dcb900fd3bec534eec63863ce956e
diff --git a/ibm_vpd_utils.cpp b/ibm_vpd_utils.cpp
index b135d5e..ef9f058 100644
--- a/ibm_vpd_utils.cpp
+++ b/ibm_vpd_utils.cpp
@@ -239,8 +239,8 @@
}
catch (const sdbusplus::exception_t& e)
{
- throw std::runtime_error(
- "Error in invoking D-Bus logging create interface to register PEL");
+ std::cerr << "Dbus call to phosphor-logging Create failed. Reason:"
+ << e.what();
}
}
diff --git a/vpd-manager/manager.cpp b/vpd-manager/manager.cpp
index 8d60014..d8b2089 100644
--- a/vpd-manager/manager.cpp
+++ b/vpd-manager/manager.cpp
@@ -554,6 +554,9 @@
void Manager::collectFRUVPD(const sdbusplus::message::object_path& path)
{
+ std::cout << "Manager called to collect vpd for fru: " << std::string{path}
+ << std::endl;
+
using InvalidArgument =
sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument;
using Argument = xyz::openbmc_project::Common::InvalidArgument;
@@ -693,6 +696,9 @@
void Manager::deleteFRUVPD(const sdbusplus::message::object_path& path)
{
+ std::cout << "Manager called to delete vpd for fru: " << std::string{path}
+ << std::endl;
+
using InvalidArgument =
sdbusplus::xyz::openbmc_project::Common::Error::InvalidArgument;
using Argument = xyz::openbmc_project::Common::InvalidArgument;