commit 719093d1284f8615f581fdf1e6895656e826e8e3
author Rekha Aparna <vrekhaaparna@ibm.com> Thu Nov 13 03:13:12 2025 -0600
committer Rekha Aparna <vrekhaaparna@ibm.com> Fri Nov 21 03:11:08 2025 -0600
tree 92bcd118937fa2c3c934de96b7c277df64fda07a
parent f526b3f884e5e5c4eb6d8a5a8806d46954a1197d

Error handling for executeCmd API

This commit updates executeCmd API to set error code in case of error.
This helps the caller of API to take action based on the error code
returned from the API.

Change-Id: Ie5b7804f5d486a278765d460eabaef0bd46d555e
Signed-off-by: Rekha Aparna <vrekhaaparna@ibm.com>

vpd-manager/oem-handler/ibm_handler.cpp

diff --git a/vpd-manager/oem-handler/ibm_handler.cpp b/vpd-manager/oem-handler/ibm_handler.cpp
index ec3597b..607ba34 100644
--- a/vpd-manager/oem-handler/ibm_handler.cpp
+++ b/vpd-manager/oem-handler/ibm_handler.cpp
@@ -4,6 +4,7 @@
 
 #include "configuration.hpp"
 #include "listener.hpp"
+#include "logger.hpp"
 #include "parser.hpp"
 
 #include <utility/common_utility.hpp>
@@ -417,6 +418,7 @@
     // iterate over each MUX detail and enable them.
     for (const auto& item : m_sysCfgJsonObj["muxes"])
     {
+        uint16_t l_errCode = 0;
         if (item.contains("holdidlepath"))
         {
             std::string cmd = "echo 0 > ";
@@ -424,7 +426,15 @@
 
             logging::logMessage("Enabling mux with command = " + cmd);
 
-            commonUtility::executeCmd(cmd);
+            commonUtility::executeCmd(cmd, l_errCode);
+
+            if (l_errCode)
+            {
+                m_logger->logMessage(
+                    "Failed to execute command [" + cmd +
+                    "], error : " + commonUtility::getErrCodeMsg(l_errCode));
+            }
+
             continue;
         }
 
@@ -507,7 +517,16 @@
                             const std::string& i_value)
 {
     // set env and reboot and break.
-    commonUtility::executeCmd("/sbin/fw_setenv", i_key, i_value);
+    uint16_t l_errCode = 0;
+    commonUtility::executeCmd("/sbin/fw_setenv", l_errCode, i_key, i_value);
+
+    if (l_errCode)
+    {
+        throw std::runtime_error(
+            "Failed to execute command [/sbin/fw_setenv " + i_key + " " +
+            i_value + "], error : " + commonUtility::getErrCodeMsg(l_errCode));
+    }
+
     logging::logMessage("Rebooting BMC to pick up new device tree");
 
     // make dbus call to reboot
@@ -520,8 +539,17 @@
 
 static std::string readFitConfigValue()
 {
+    uint16_t l_errCode = 0;
     std::vector<std::string> l_output =
-        commonUtility::executeCmd("/sbin/fw_printenv");
+        commonUtility::executeCmd("/sbin/fw_printenv", l_errCode);
+
+    if (l_errCode)
+    {
+        Logger::getLoggerInstance()->logMessage(
+            "Failed to execute command [/sbin/fw_printenv], error : " +
+            commonUtility::getErrCodeMsg(l_errCode));
+    }
+
     std::string l_fitConfigValue;
 
     for (const auto& l_entry : l_output)