Add Type = RackMount to Chassis
Most IBM servers are RackMount Chassis so anywhere we create the
/system/chassis, set Type to
xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount.
One day, we could set this dynamically for tower models.
This is needed because
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/75914 added support for
dynamic ChassisType. Before 75914, ChassisType was hardcoded to
RackMount. If you implement Inventory.Item.Chassis the default Chassis
Type is Unknown. Unknown in 75914 maps to Invalid and ChassisType is
left off the Redfish Chassis resource. The Redfish Validator flags this
as an error since ChassisType is a required property in the Chassis
schema.
bmcweb bumps are failing with
'''
ERROR - ChassisType: Mandatory prop does not exist
'''
Discussed in discord at [1].
[1]: https://discord.com/channels/775381525260664832/855566794994221117/1316067028242661397
Tested: With the latest bmcweb see "ChassisType": "RackMount", for
/redfish/v1/Chassis/chassis
Change-Id: Ib30e7610d0dbe21d52b90764863085bc47d75e00
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/config/ibm/50001000.json b/config/ibm/50001000.json
index 03f2ce8..677394c 100644
--- a/config/ibm/50001000.json
+++ b/config/ibm/50001000.json
@@ -81,7 +81,9 @@
"inventoryPath": "/system/chassis",
"isSystemVpd": true,
"extraInterfaces": {
- "xyz.openbmc_project.Inventory.Item.Chassis": null,
+ "xyz.openbmc_project.Inventory.Item.Chassis": {
+ "Type": "xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount"
+ },
"xyz.openbmc_project.Inventory.Item.Global": null,
"com.ibm.ipzvpd.Location": {
"LocationCode": "Ufcs"
diff --git a/config/ibm/50001000_v2.json b/config/ibm/50001000_v2.json
index ed06dd0..f80f61d 100644
--- a/config/ibm/50001000_v2.json
+++ b/config/ibm/50001000_v2.json
@@ -103,7 +103,9 @@
"inventoryPath": "/system/chassis",
"isSystemVpd": true,
"extraInterfaces": {
- "xyz.openbmc_project.Inventory.Item.Chassis": null,
+ "xyz.openbmc_project.Inventory.Item.Chassis": {
+ "Type": "xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount"
+ },
"xyz.openbmc_project.Inventory.Item.Global": null,
"com.ibm.ipzvpd.Location": {
"LocationCode": "Ufcs"
diff --git a/config/ibm/50001001.json b/config/ibm/50001001.json
index fb1e74e..2d11a2a 100644
--- a/config/ibm/50001001.json
+++ b/config/ibm/50001001.json
@@ -81,7 +81,9 @@
"inventoryPath": "/system/chassis",
"isSystemVpd": true,
"extraInterfaces": {
- "xyz.openbmc_project.Inventory.Item.Chassis": null,
+ "xyz.openbmc_project.Inventory.Item.Chassis": {
+ "Type": "xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount"
+ },
"xyz.openbmc_project.Inventory.Item.Global": null,
"com.ibm.ipzvpd.Location": {
"LocationCode": "Ufcs"
diff --git a/config/ibm/50001001_v2.json b/config/ibm/50001001_v2.json
index 22bdaab..ae7e7c6 100644
--- a/config/ibm/50001001_v2.json
+++ b/config/ibm/50001001_v2.json
@@ -103,7 +103,9 @@
"inventoryPath": "/system/chassis",
"isSystemVpd": true,
"extraInterfaces": {
- "xyz.openbmc_project.Inventory.Item.Chassis": null,
+ "xyz.openbmc_project.Inventory.Item.Chassis": {
+ "Type": "xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount"
+ },
"xyz.openbmc_project.Inventory.Item.Global": null,
"com.ibm.ipzvpd.Location": {
"LocationCode": "Ufcs"
diff --git a/config/ibm/50001002.json b/config/ibm/50001002.json
index a80c034..0f5a0ab 100644
--- a/config/ibm/50001002.json
+++ b/config/ibm/50001002.json
@@ -93,7 +93,9 @@
"inventoryPath": "/system/chassis",
"isSystemVpd": true,
"extraInterfaces": {
- "xyz.openbmc_project.Inventory.Item.Chassis": null,
+ "xyz.openbmc_project.Inventory.Item.Chassis": {
+ "Type": "xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount"
+ },
"xyz.openbmc_project.Inventory.Item.Global": null,
"com.ibm.ipzvpd.Location": {
"LocationCode": "Ufcs"
diff --git a/config/ibm/50003000.json b/config/ibm/50003000.json
index cd207ff..a8d71dd 100644
--- a/config/ibm/50003000.json
+++ b/config/ibm/50003000.json
@@ -98,7 +98,9 @@
"inventoryPath": "/system/chassis",
"isSystemVpd": true,
"extraInterfaces": {
- "xyz.openbmc_project.Inventory.Item.Chassis": null,
+ "xyz.openbmc_project.Inventory.Item.Chassis": {
+ "Type": "xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount"
+ },
"xyz.openbmc_project.Inventory.Item.Global": null,
"com.ibm.ipzvpd.Location": {
"LocationCode": "Ufcs"
diff --git a/config/ibm/50003000_v2.json b/config/ibm/50003000_v2.json
index e871caa..f6101e5 100644
--- a/config/ibm/50003000_v2.json
+++ b/config/ibm/50003000_v2.json
@@ -98,7 +98,9 @@
"inventoryPath": "/system/chassis",
"isSystemVpd": true,
"extraInterfaces": {
- "xyz.openbmc_project.Inventory.Item.Chassis": null,
+ "xyz.openbmc_project.Inventory.Item.Chassis": {
+ "Type": "xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount"
+ },
"xyz.openbmc_project.Inventory.Item.Global": null,
"com.ibm.ipzvpd.Location": {
"LocationCode": "Ufcs"
diff --git a/config/ibm/vpd_inventory.json b/config/ibm/vpd_inventory.json
index 9db972b..a949d90 100644
--- a/config/ibm/vpd_inventory.json
+++ b/config/ibm/vpd_inventory.json
@@ -74,7 +74,9 @@
"inherit": false,
"isSystemVpd": true,
"extraInterfaces": {
- "xyz.openbmc_project.Inventory.Item.Chassis": null,
+ "xyz.openbmc_project.Inventory.Item.Chassis": {
+ "Type": "xyz.openbmc_project.Inventory.Item.Chassis.ChassisType.RackMount"
+ },
"com.ibm.ipzvpd.Location": {
"LocationCode": "Ufcs"
}