Memory VPD parser review comments
In this commit review comments have been addressed for Memory vpd parser.
Change-Id: Ib9a67083048479ba3406a1932df3868d3953102c
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>
diff --git a/vpd-parser/memory_vpd_parser.cpp b/vpd-parser/memory_vpd_parser.cpp
index 6a4c608..3793ae0 100644
--- a/vpd-parser/memory_vpd_parser.cpp
+++ b/vpd-parser/memory_vpd_parser.cpp
@@ -21,13 +21,13 @@
{
KeywordVpdMap map{};
- vector<uint8_t> partNumber(iterator, iterator + PART_NUM_LEN);
+ Binary partNumber(iterator, iterator + PART_NUM_LEN);
advance(iterator, PART_NUM_LEN);
- vector<uint8_t> serialNumber(iterator, iterator + SERIAL_NUM_LEN);
+ Binary serialNumber(iterator, iterator + SERIAL_NUM_LEN);
advance(iterator, SERIAL_NUM_LEN);
- vector<uint8_t> ccin(iterator, iterator + CCIN_LEN);
+ Binary ccin(iterator, iterator + CCIN_LEN);
map.emplace("PN", move(partNumber));
map.emplace("SN", move(serialNumber));
@@ -38,12 +38,6 @@
variant<kwdVpdMap, Store> memoryVpdParser::parse()
{
- // check if vpd file is empty
- if (memVpd.empty())
- {
- throw runtime_error("VPD file is empty.");
- }
-
// Read the data and return the map
auto iterator = memVpd.cbegin();
// point the iterator to DIMM data and skip "11S"