commit	8cc5b15ca630e3f2daf6a6ef5c8b19dd1b6349e2	[log] [tgz]
author	PriyangaRamasamy <priyanga24@in.ibm.com>	Thu Jun 03 13:05:17 2021 -0500
committer	Priyanga Ramasamy <priyanga24@in.ibm.com>	Thu Jul 29 04:10:32 2021 -0500
tree	53fb82264cecc68c4c42eccde754f14ca1afe31a
parent	b0f3749d793ff1e11310ca5b729274afbbd85241 [diff]

Vpd-tool defect fix:data not shown for primed objects

Issue:
Some of the primed objects data were not shown by vpd-tool.

For those inventory paths whose inherit is true, the tool checks for
specific VINI properties presence. If any VINI property is not present,
the tool considered dbus object itself is not present.
And the output json was emplaced with null object.

Thus ended up in showing empty data for primed frus
with no common interfaces properties.

Fix:
Emplace null object for the inventory path, only when the
inventory path is not found in dbus.

Other Fixes:

-> Removed checking inherit value, as whether or not inherit
is true/false, we need both common interfaces and location
code(for some frus like powersupply).

  So in this fix, if the common interface keywords are
  not present, we ignore and get only the extra interfaces
  properties.

-> Removed unwanted null object emplacement.
-> Logic which adds fan type interface for fan frus.

Tested on rainier:

1. Frus without common interface properties are displayed with
its extra interface properties.

"/system/chassis/motherboard/dimm29": {
            "LocationCode": "U78DB.ND0.WZS000G-P0-C46",
            "TYPE": "FRU",
            "type": "xyz.openbmc_project.Inventory.Item.Dimm"
        },
"/system/chassis/motherboard/dimm3": {
            "LocationCode": "U78DB.ND0.WZS000G-P0-C17",
            "TYPE": "FRU",
            "type": "xyz.openbmc_project.Inventory.Item.Dimm"
        },

2. cable card10 and its connectors are physically present on the
system

"/system/chassis/motherboard/pcie_cable_card10": {
            "CC": "6B87",
            "DR": "NVME JBOF  RISER",
            "FN": "03FL205",
            "LocationCode": "U78DA.ND0.WZS004K-P0-C10",
            "PN": "03FL204",
            "SN": "YA31UF07200Z",
            "TYPE": "FRU",
            "type": "xyz.openbmc_project.Inventory.Item.FabricAdapter"
        },
        "/system/chassis/motherboard/pcie_cable_card10/cxp_bot": {
            "LocationCode": "U78DA.ND0.WZS004K-P0-C10-T1",
            "TYPE": "FRU",
            "type": "xyz.openbmc_project.Inventory.Item.Connector"
        },
        "/system/chassis/motherboard/pcie_cable_card10/cxp_top": {
            "LocationCode": "U78DA.ND0.WZS004K-P0-C10-T0",
            "TYPE": "FRU",
            "type": "xyz.openbmc_project.Inventory.Item.Connector"
        },

3. cable card3 and its connectors are not present on the system

        "/system/chassis/motherboard/pcie_cable_card3": {
            "LocationCode": "U78DA.ND0.WZS004K-P0-C3",
            "TYPE": "FRU",
            "type": "xyz.openbmc_project.Inventory.Item.FabricAdapter"
            },
        "/system/chassis/motherboard/pcie_cable_card3/cxp_bot": {},
        "/system/chassis/motherboard/pcie_cable_card3/cxp_top": {},

4. Fan frus showing up with its Item inteface

"/system/chassis/motherboard/fan1": {
            "LocationCode": "U78DB.ND0.WZS000G-A1",
            "type": "xyz.openbmc_project.Inventory.Item.Fan"
        },

Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: I38467642944fffec381d070d2a1a7dd3b9882399

4 files changed

tree: 53fb82264cecc68c4c42eccde754f14ca1afe31a

README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

The supported records and keywords.
How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
Add details to the README on how to configure and build the application.
More JSON documentation.
Support for more IBM VPD formats.
VPD Write and tool documentation.