PEL creation in case of HW/SW failure.
Creation of PEL in case the parser process fails to parse and/or publish
VPD data.
This commit handles both hardware or software failure and creates PEL
accordingly.
Tested on Simics.
Test procedure:
Step1 : Copy ibm_read_vpd in /tmp folder on simics
Step2 : Run ibm_read_vpd exe with a vpd file path having invalid VPD/ECC or
invalid JSON path. In this case we have given path to VPD file with
invalid VPD data.
command-> ./ibm_read_vpd --file <vpd_file_path>
Step3 : After the execution is over, look for PEL logged using command
"peltool -a"
PEL logged incase of invalid VPD:
[
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x4000",
"Created at": "11/27/2020 04:40:00",
"Committed at": "11/27/2020 04:40:00",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x50000002",
"Entry Id": "0x50000002",
"BMC Event Log Id": "2"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware: VPD Interface",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent"
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x4000",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Power Control Net Fault": "False",
"Backplane CCIN": "2E2D",
"Error Details": {
"Message": "A VPD data exception occurred."
},
"Valid Word Count": "0x09",
"Reference Code": "BD554001",
"Hex Word 2": "00000055",
"Hex Word 3": "2E2D0010",
"Hex Word 4": "00000000",
"Hex Word 5": "00000000",
"Hex Word 6": "00000000",
"Hex Word 7": "00000000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Normal Hardware FRU",
"Priority": "Mandatory, replace all with this type as a unit",
"Location Code": "U78DA.ND1.1234567-P0",
"Part Number": "F191014",
"CCIN": "2E2D",
"Serial Number": "YL2E2D010000"
}]
}
},
"Extended User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x2000",
"Reporting Machine Type": "9105-22A",
"Reporting Serial Number": "SIMP10R",
"FW Released Ver": "",
"FW SubSys Version": "fw1020.00-6",
"Common Ref Time": "00/00/0000 00:00:00",
"Symptom Id Len": "20",
"Symptom Id": "BD554001_2E2D0010"
},
"Failing MTMS": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x2000",
"Machine Type Model": "9105-22A",
"Serial Number": "SIMP10R"
},
"User Data 0": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"BMC Version ID": "fw1020.00-6-22-gbbd23f832",
"BMCState": "Ready",
"ChassisState": "Off",
"HostState": "Off",
"Process Name": "Unknown"
},
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"CALLOUT_INVENTORY_PATH": "/xyz/openbmc_project/inventory/system/chassis/motherboard",
"DESCRIPTION": "Invalid VPD data"
}
}
]
Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: Ieb434bb45b4051d8b7b6d4c9022984d5471fc855
diff --git a/utils.cpp b/utils.cpp
index 24d7b4c..8b33305 100644
--- a/utils.cpp
+++ b/utils.cpp
@@ -12,31 +12,38 @@
namespace vpd
{
using namespace openpower::vpd::constants;
+using namespace inventory;
+using namespace phosphor::logging;
+
namespace inventory
{
-auto getPIMService()
+std::string getService(sdbusplus::bus::bus& bus, const std::string& path,
+ const std::string& interface)
{
- auto bus = sdbusplus::bus::new_default();
- auto mapper =
- bus.new_method_call("xyz.openbmc_project.ObjectMapper",
- "/xyz/openbmc_project/object_mapper",
- "xyz.openbmc_project.ObjectMapper", "GetObject");
-
- mapper.append(pimPath);
- mapper.append(std::vector<std::string>({pimIntf}));
-
- auto result = bus.call(mapper);
- if (result.is_method_error())
- {
- throw std::runtime_error("ObjectMapper GetObject failed");
- }
+ auto mapper = bus.new_method_call(mapperDestination, mapperObjectPath,
+ mapperInterface, "GetObject");
+ mapper.append(path, std::vector<std::string>({interface}));
std::map<std::string, std::vector<std::string>> response;
- result.read(response);
+ try
+ {
+ auto reply = bus.call(mapper);
+ reply.read(response);
+ }
+ catch (const sdbusplus::exception::SdBusError& e)
+ {
+ log<level::ERR>("D-Bus call exception",
+ entry("OBJPATH=%s", mapperObjectPath),
+ entry("INTERFACE=%s", mapperInterface),
+ entry("EXCEPTION=%s", e.what()));
+
+ throw std::runtime_error("Service name is not found");
+ }
+
if (response.empty())
{
- throw std::runtime_error("ObjectMapper GetObject bad response");
+ throw std::runtime_error("Service name response is empty");
}
return response.begin()->first;
@@ -44,12 +51,10 @@
void callPIM(ObjectMap&& objects)
{
- std::string service;
-
try
{
- service = getPIMService();
auto bus = sdbusplus::bus::new_default();
+ auto service = getService(bus, pimPath, pimIntf);
auto pimMsg =
bus.new_method_call(service.c_str(), pimPath, pimIntf, "Notify");
pimMsg.append(std::move(objects));
@@ -174,5 +179,27 @@
}
return propVal;
}
+
+void createPEL(const std::map<std::string, std::string>& additionalData,
+ const std::string& errIntf)
+{
+ try
+ {
+ auto bus = sdbusplus::bus::new_default();
+
+ auto service = getService(bus, loggerObjectPath, loggerCreateInterface);
+ auto method = bus.new_method_call(service.c_str(), loggerObjectPath,
+ loggerCreateInterface, "Create");
+
+ method.append(errIntf, "xyz.openbmc_project.Logging.Entry.Level.Error",
+ additionalData);
+ auto resp = bus.call(method);
+ }
+ catch (const sdbusplus::exception::SdBusError& e)
+ {
+ throw std::runtime_error(
+ "Error in invoking D-Bus logging create interface to register PEL");
+ }
+}
} // namespace vpd
} // namespace openpower