commit a4a2adfa96d2c491b1baf776013a6442bc88c78b
author Priyanga Ramasamy <priyanga24@in.ibm.com> Thu Feb 03 05:43:41 2022 -0600
committer Santosh Puranik <santosh.puranik@in.ibm.com> Mon Apr 25 04:19:50 2022 +0000
tree 0f3ae7e7fa105b279b366e6da37ffd213f6ea6b1
parent bf78ed8883a067d6f297860ceb54dbd6148b2d25

VPD ECC shared library

This commit makes the VPD ECC source into a shared library
and links the shared library with other executables which
are dependant on VPD ECC.

Since the ECC source file is confidential, we need to share the
ECC as a shared library to the IBM Power customers.

Test:
Tested on simics:
1. Corrupted the vpd data.
root@p10bmc:/usr/lib# dd if=/dev/zero of=/sys/bus/i2c/drivers/at24/7-0050/eeprom bs=1 count=2 seek=184
2+0 records in
2+0 records out

root@p10bmc:/usr/lib# ibm-read-vpd --file /sys/bus/i2c/drivers/at24/7-0050/eeprom
ERROR: ECC check did not pass for the Record:VINI

2. VPD Parser parsed successfully for a valid vpd
root@p10bmc:/usr/lib# ibm-read-vpd --file /sys/bus/i2c/drivers/at24/7-0050/eeprom
<no error>

3.ECC Code worked fine with VPD-Manager
root@p10bmc:/usr/lib# vpd-tool -w -O /system/chassis/motherboard/base_op_panel_blyth -R VINI -K PN -V "PN34"
root@p10bmc:/usr/lib# ibm-read-vpd --file /sys/bus/i2c/drivers/at24/7-0050/eeprom
root@p10bmc:/usr/lib#
root@p10bmc:/usr/lib#
root@p10bmc:/usr/lib# vpd-tool -w -O /system/chassis/motherboard/base_op_panel_blyth -R VINI -K PN -V "PN12"
root@p10bmc:/usr/lib# ibm-read-vpd --file /sys/bus/i2c/drivers/at24/7-0050/eeprom

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I72306b06ca8724193ef5ef05a0659467994a154d

meson.build

diff --git a/meson.build b/meson.build
index f1bc49f..304c4c9 100644
--- a/meson.build
+++ b/meson.build
@@ -60,6 +60,18 @@
 
 sdbusplus = dependency('sdbusplus', fallback: [ 'sdbusplus', 'sdbusplus_dep' ])
 
+libvpdecc_src = files(
+    'vpdecc/vpdecc.c',
+    'vpdecc/vpdecc_support.c'
+)
+
+libvpdecc = shared_library(
+    'vpdecc',
+    libvpdecc_src,
+    version: meson.project_version(),
+    install: true,
+)
+
 if not build_tests.disabled()
     subdir('test')
 endif
@@ -100,7 +112,6 @@
                  'vpd-parser/memory_vpd_parser.cpp',
                  'vpd-parser/keyword_vpd_parser.cpp',
                  'vpd-parser/ipz_parser.cpp', 'impl.cpp', 'ibm_vpd_utils.cpp',
-                 'vpdecc/vpdecc.c', 'vpdecc/vpdecc_support.c'
 ]
 
 if get_option('ibm-parser').enabled()
@@ -116,6 +127,7 @@
                                         phosphor_logging,
                                         libgpiodcxx,
                                 ],
+                                link_with : libvpdecc,
                                 include_directories : 'vpd-parser/',
                                 install: true,
                                 cpp_args : '-DIPZ_PARSER'
@@ -135,6 +147,7 @@
                                    sdbusplus,
                                    libgpiodcxx
                                    ],
+                                 link_with : libvpdecc,
                                  install: true,
                                  include_directories : vpd_tool_INCLUDE
                                  )

test/meson.build

diff --git a/test/meson.build b/test/meson.build
index 36d5383..c9ddf1b 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -24,8 +24,6 @@
 ]
 
 application_src =['../impl.cpp',
-                   '../vpdecc/vpdecc.c',
-                   '../vpdecc/vpdecc_support.c',
                    '../vpd-parser/ipz_parser.cpp',
                    '../ibm_vpd_utils.cpp',
                    '../common_utility.cpp',
@@ -45,7 +43,8 @@
     c_args: ['-Wno-unused-parameter',
       '-Wno-unused-variable'],
     dependencies: dependecy_list,
-    include_directories: configuration_inc
+    include_directories: configuration_inc,
+    link_with : libvpdecc,
     ),
     workdir: meson.current_source_dir())
 endforeach

vpd-manager/meson.build

diff --git a/vpd-manager/meson.build b/vpd-manager/meson.build
index b6ffa60..604f2b6 100644
--- a/vpd-manager/meson.build
+++ b/vpd-manager/meson.build
@@ -15,8 +15,6 @@
                       '../vpd-parser/ipz_parser.cpp',
                       '../ibm_vpd_utils.cpp',
                       '../common_utility.cpp',
-                      '../vpdecc/vpdecc.c',
-                      '../vpdecc/vpdecc_support.c',
                       '../vpd-parser//keyword_vpd_parser.cpp',
                       '../vpd-parser/memory_vpd_parser.cpp',
                       '../vpd-parser/parser_factory.cpp'
@@ -37,5 +35,6 @@
                  dependencies : [
                                 vpd_manager_dependencies,
                                 ],
+                 link_with : libvpdecc,
                  install : true
                 )