Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / e5f177a5f08c5dfc9a11770c4270080cee73bd92
commite5f177a5f08c5dfc9a11770c4270080cee73bd92[log] [tgz]
authorSantosh Puranik <santosh.puranik@in.ibm.com>Mon Jan 24 20:14:46 2022 +0530
committerSantosh Puranik <santosh.puranik@in.ibm.com>Thu Jan 27 16:44:52 2022 +0530
treea11fccc94c4196b315195ff9b4b08c2fb150eeed
parent3723378568ede32203bbbb76f86083db50978803 [diff]
Fix HW Keyword Handling

This commit fixes how we handle multiple planar passes.
For HW keywords above 2, we do not have an entry in the
system type map.

We cannot keep adding a new entry to the system type to dev.
tree map every time we get a new planar pass (when the new pass
does not need a new device tree).

This commit makes use of existing code that handles
constraints in the systems JSON and enables us to default
to a system type (which is basically our JSON name) when the
constraint is not met.

Tested:
Tested on a pass 4 planar and ensured we load the right device
tree.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: Ibaf9785314ca3920072663d52fffecfca28c9445
2 files changed
tree: a11fccc94c4196b315195ff9b4b08c2fb150eeed
  1. examples/
  2. subprojects/
  3. test/
  4. vpd-manager/
  5. vpd-parser/
  6. vpdecc/
  7. .clang-format
  8. .gitignore
  9. app.cpp
  10. args.cpp
  11. args.hpp
  12. common_utility.cpp
  13. common_utility.hpp
  14. const.hpp
  15. defines.hpp
  16. extra-properties-example.yaml
  17. extra-properties.mako.hpp
  18. extra-properties.py
  19. ibm_vpd_app.cpp
  20. ibm_vpd_utils.cpp
  21. ibm_vpd_utils.hpp
  22. impl.cpp
  23. impl.hpp
  24. LICENSE
  25. MAINTAINERS
  26. meson.build
  27. meson_options.txt
  28. OWNERS
  29. README.md
  30. store.hpp
  31. types.hpp
  32. utilInterface.hpp
  33. vpd_exceptions.hpp
  34. vpd_tool.cpp
  35. vpd_tool_impl.cpp
  36. vpd_tool_impl.hpp
  37. write.cpp
  38. write.hpp
  39. writefru.mako.hpp
  40. writefru.py
  41. writefru.yaml
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.