Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / b00b92affa78574fc608e21a1612db19592b2d6b
commitb00b92affa78574fc608e21a1612db19592b2d6b[log] [tgz]
authorSouvik Roy <souvikroyofficial10@gmail.com>Mon Sep 08 16:05:45 2025 +0000
committerSunnySrivastava <sunnsr25@in.ibm.com>Tue Sep 09 06:16:03 2025 +0000
tree22eecce22f9f2fa35c9b4cf28dfd85e93aeb14d7
parentb50bf0eac3d7f7ad3878af1173d9fdcfcb871e8a [diff]
Fix missing ECC update error log

This commit fixes ECC update error log. Currently, when vpd-tool
writeKeyword option fails due to failure in updating the record ECC in
ipz parser's writeKeywordToHardware method, an ECC exception message is
thrown up the call stack and gets logged in parser.cpp, however the
contents of the exception message get lost. This commit fixes the
missing error message.

Test:
```
- Ensure ECC update fails for given record
- Execute vpd-tool writeKeyword
- Observe following error log:

Sep 08 16:08:30 p11bmc vpd-manager[1109]: FileName: /usr/src/debug/
openpower-fru-vpd/1.0+git/vpd-manager/src/parser.cpp, Line: 226 Update
VPD Keyword failed for : VINI:PN failed due to error: Error while
updating keyword's value on hardware path /sys/bus/i2c/drivers/at24/
7-0050/eeprom, error: ECC update failed with error -1
```

Change-Id: I7a4ae822121d26618d5952f518f99d006d74441b
Signed-off-by: Souvik Roy <souvikroyofficial10@gmail.com>
1 file changed
tree: 22eecce22f9f2fa35c9b4cf28dfd85e93aeb14d7
  1. configuration/
  2. docs/
  3. service_files/
  4. test/
  5. vpd-manager/
  6. vpd-tool/
  7. vpdecc/
  8. wait-vpd-parser/
  9. .clang-format
  10. .gitignore
  11. LICENSE
  12. meson.build
  13. meson.options
  14. OWNERS
  15. README.md
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found at a broken link.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.