Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / b1e64bb6fa2605b41583a150c90812f756e2590b
commitb1e64bb6fa2605b41583a150c90812f756e2590b[log] [tgz]
authorMatt Spinler <spinler@us.ibm.com>Wed Sep 08 09:57:48 2021 -0500
committerSantosh Puranik <santosh.puranik@in.ibm.com>Tue Sep 14 15:53:28 2021 +0000
tree6f1dc9c188e2452bb3871f872c8e1a8dd28afeac
parentd3a379a6b259a0cd4b7b1af700079b31a6a492b2 [diff]
Support size_t properties on extraInterfaces

The xyz...I2CDevice interface is needed on certain FRU object paths so
that entity-manager can know the EEPROM I2C bus and address.  It has two
size_t properties, Bus and Address.

This commit adds support for this by looking for numeric JSON properties
in the extraInterfaces JSON and saving them in the PIM payload as
size_t.

A future improvement would be to figure out the exact type needed, such
as uint64_t, int, etc.

Tested: Saw the interface on D-Bus:
xyz.openbmc_project.Inventory.Decorator.I2CDevice
.Address                                              81
.Bus                                                  30

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Iad92917b53e0dc9fdc7cd95d7452e41a8a7f6510
1 file changed
tree: 6f1dc9c188e2452bb3871f872c8e1a8dd28afeac
  1. examples/
  2. subprojects/
  3. test/
  4. vpd-manager/
  5. vpd-parser/
  6. vpdecc/
  7. .clang-format
  8. .gitignore
  9. app.cpp
  10. args.cpp
  11. args.hpp
  12. common_utility.cpp
  13. common_utility.hpp
  14. const.hpp
  15. defines.hpp
  16. extra-properties-example.yaml
  17. extra-properties.mako.hpp
  18. extra-properties.py
  19. ibm_vpd_app.cpp
  20. ibm_vpd_utils.cpp
  21. ibm_vpd_utils.hpp
  22. impl.cpp
  23. impl.hpp
  24. LICENSE
  25. MAINTAINERS
  26. meson.build
  27. meson_options.txt
  28. README.md
  29. store.hpp
  30. types.hpp
  31. utilInterface.hpp
  32. vpd_exceptions.hpp
  33. vpd_tool.cpp
  34. vpd_tool_impl.cpp
  35. vpd_tool_impl.hpp
  36. write.cpp
  37. write.hpp
  38. writefru.mako.hpp
  39. writefru.py
  40. writefru.yaml
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.