Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / cfd7a75ab49d18abbba4585c392ca12d295e7775
commitcfd7a75ab49d18abbba4585c392ca12d295e7775[log] [tgz]
authorAlpana Kumari <alpankum@in.ibm.com>Sun Feb 07 23:23:01 2021 -0600
committerAlpana Kumari <alpankum@in.ibm.com>Wed Feb 10 01:07:21 2021 -0600
tree7803db5000012f9afcdcafe7046336bb49b55659
parent9094d4f6453ca8fcca2d6d62967631cb8bedbcc6 [diff]
Set Presence as False for all the FRUs

While priming the inventory all the frus (except the System), presence state should be false
It will be set as true when vpd collection done for that fru.

Test-
By code I could change the value of Present

root@rain148bmc:/tmp# busctl introspect  xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcie_cable_card8|more
NAME                                          TYPE      SIGNATURE RESULT/VALUE              FLAGS
xyz.openbmc_project.Inventory.Item            interface -         -                         -
.Present                                      property  b         true                      emits-change writable
.PrettyName                                   property  s         "DBG_TESTING"             emits-change writable

root@rain148bmc:/tmp# busctl introspect  xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcie_cable_card8
xyz.openbmc_project.Inventory.Item            interface -         -                         -
.Present                                      property  b         false

root@rain147bmc:/tmp# busctl introspect  xyz.openbmc_project.Inventory.Manager  /xyz/openbmc_project/inventory/system/chassis/motherboard/pcie_cable_card8
NAME                                          TYPE      SIGNATURE RESULT/VALUE              FLAGS
xyz.openbmc_project.Inventory.Item            interface -         -                         -
.Present                                      property  b         false                     emits-change writable

root@rain147bmc:/tmp# busctl introspect  xyz.openbmc_project.Inventory.Manager  /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill
NAME                                     TYPE      SIGNATURE RESULT/VALUE           FLAGS
xyz.openbmc_project.Inventory.Item       interface -         -                      -
.Present                                 property  b         false                  emits-change writable

Change-Id: I8f60c453761cd5d524b5f47aaf0228f72560d6a7
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>
1 file changed
tree: 7803db5000012f9afcdcafe7046336bb49b55659
  1. examples/
  2. test/
  3. vpd-manager/
  4. vpd-parser/
  5. vpdecc/
  6. .clang-format
  7. .gitignore
  8. app.cpp
  9. args.cpp
  10. args.hpp
  11. const.hpp
  12. defines.hpp
  13. extra-properties-example.yaml
  14. extra-properties.mako.hpp
  15. extra-properties.py
  16. ibm_vpd_app.cpp
  17. impl.cpp
  18. impl.hpp
  19. LICENSE
  20. MAINTAINERS
  21. meson.build
  22. meson_options.txt
  23. README.md
  24. store.hpp
  25. types.hpp
  26. utilInterface.hpp
  27. utils.cpp
  28. utils.hpp
  29. vpd_exceptions.hpp
  30. vpd_tool.cpp
  31. vpd_tool_impl.cpp
  32. vpd_tool_impl.hpp
  33. write.cpp
  34. write.hpp
  35. writefru.mako.hpp
  36. writefru.py
  37. writefru.yaml
README.md

#Overview This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.