Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / f04c17494ce93764dd81fc8bbc2feda2196a2e7a
commitf04c17494ce93764dd81fc8bbc2feda2196a2e7a[log] [tgz]
authorPriyanga Ramasamy <priyanga24@in.ibm.com>Wed Oct 16 05:29:41 2024 -0500
committerJinu Joy Thomas <jinu.joy.thomas@in.ibm.com>Mon Nov 04 08:55:22 2024 +0000
tree20b774a0e2732174103a10c48636ce3616fc8857
parent4be52ac62b6cf38b57c309c6534fda48c44d811e [diff]
Everest:Missing EXP_PRSNT GPIO pin for PCIe cards

In everest VPD JSON, "presence" section with expander presence gpio
pin information is missing for PCIe cards. Due to which during FRU
VPD collection, I2C line for PCIe card VPD is enabled without
checking if IBM specific PCIe card is actually present on the system.

This check is required for PCIe cards because the PCIe slot accepts
both IBM specific cards and any industry standard cards. So during VPD
collection before enabling the I2C line of PCIe card VPD, it's
recommended to check if IBM standard PCIe card is present on
IBM system.

Test:
'''
busctl call com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager
CollectFRUVPD o "/xyz/openbmc_project/inventory/system/chassis/motherboard
/pcieslot2/pcie_card2"

Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Setting GPIO: presence-cable-card2 to 1
Oct 16 13:10:40 ever6bmc vpd-manager[1929]: Executing driver binding
for chip address - 17-0060
Oct 16 13:10:40 ever6bmc kernel: at24 17-0050: 8192 byte 24c64 EEPROM,
writable, 1 bytes/write
Oct 16 13:10:40 ever6bmc kernel: leds-pca955x 17-0060: leds-pca955x:
Using pca9551 8-bit LED driver at slave address 0x60
Oct 16 13:10:40 ever6bmc kernel: leds-pca955x 17-0060: gpios 1040...1047
Oct 16 13:10:40 ever6bmc systemd[1]: Started IPZ format VPD Parser service for
FRU sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e78a280.i2c-bus/i2c-4
/i2c-17/17-0050/17-005060.
'''
Change-Id: I92e795e3996cfa0cc7acc04605c59a550755ef85
Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
1 file changed
tree: 20b774a0e2732174103a10c48636ce3616fc8857
  1. config/
  2. examples/
  3. rules/
  4. scripts/
  5. service_files/
  6. subprojects/
  7. test/
  8. vpd-manager/
  9. vpd-parser/
  10. vpdecc/
  11. .clang-format
  12. .gitignore
  13. app.cpp
  14. args.cpp
  15. args.hpp
  16. common_utility.cpp
  17. common_utility.hpp
  18. const.hpp
  19. defines.hpp
  20. extra-properties-example.yaml
  21. extra-properties.mako.hpp
  22. extra-properties.py
  23. ibm_vpd_app.cpp
  24. ibm_vpd_utils.cpp
  25. ibm_vpd_utils.hpp
  26. impl.cpp
  27. impl.hpp
  28. LICENSE
  29. meson.build
  30. meson.options
  31. OWNERS
  32. README.md
  33. store.hpp
  34. types.hpp
  35. utilInterface.hpp
  36. vpd_exceptions.hpp
  37. vpd_tool.cpp
  38. vpd_tool_impl.cpp
  39. vpd_tool_impl.hpp
  40. write.cpp
  41. write.hpp
  42. writefru.mako.hpp
  43. writefru.py
  44. writefru.yaml
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) tocf determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.