Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / openpower-vpd-parser / e9c575354bb7216ebee6756ceb8b2ef174a3b7cc
commite9c575354bb7216ebee6756ceb8b2ef174a3b7cc[log] [tgz]
authorSantosh Puranik <santosh.puranik@in.ibm.com>Tue Mar 15 16:51:51 2022 +0530
committerSantosh Puranik <santosh.puranik@in.ibm.com>Wed Apr 20 04:48:50 2022 +0000
tree4abeab609365dee059f477422f3a05f0f05eaa98
parent53b38ed09ab95deacaada1e9b70b766d922ad409 [diff]
Do not collect VPD unless required

This commit adds some checks before we attempt VPD collection
on udev events. The following conditions are added:

-- Check if the FRU is marked concurrently maintainable or pluggable at
standby. If either is true, proceed.

-- Check if the BMC is at a NotReady state - if yes, proceeed.

-- Check if the FRU has never been colelcted before (Present is false) -
if yes, proceed.

In all other scenarios, the collection is skipped. This helps eliminate
cases where grabbing the SPI mux causes a whole bunch of parsers to run,
and an immediate power on leads to I2C arbitration loss errors.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: I8f92014e1fc0becf5f7c56019a31bb2e46c6ccf0
1 file changed
tree: 4abeab609365dee059f477422f3a05f0f05eaa98
  1. examples/
  2. subprojects/
  3. test/
  4. vpd-manager/
  5. vpd-parser/
  6. vpdecc/
  7. .clang-format
  8. .gitignore
  9. app.cpp
  10. args.cpp
  11. args.hpp
  12. common_utility.cpp
  13. common_utility.hpp
  14. const.hpp
  15. defines.hpp
  16. extra-properties-example.yaml
  17. extra-properties.mako.hpp
  18. extra-properties.py
  19. ibm_vpd_app.cpp
  20. ibm_vpd_utils.cpp
  21. ibm_vpd_utils.hpp
  22. impl.cpp
  23. impl.hpp
  24. LICENSE
  25. MAINTAINERS
  26. meson.build
  27. meson_options.txt
  28. OWNERS
  29. README.md
  30. store.hpp
  31. types.hpp
  32. utilInterface.hpp
  33. vpd_exceptions.hpp
  34. vpd_tool.cpp
  35. vpd_tool_impl.cpp
  36. vpd_tool_impl.hpp
  37. write.cpp
  38. write.hpp
  39. writefru.mako.hpp
  40. writefru.py
  41. writefru.yaml
README.md

Overview

This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.

The repository consists of two distinct applications, which are:

OpenPower VPD Parser

This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:

  • The supported records and keywords.
  • How VPD data is translated into D-Bus interfaces and properties.

The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.

IBM VPD Parser

This parser is can be built by passing in the --enable-ibm-parser configure option. This parser differs from the OpenPower VPD parser in the following ways:

  • It parses all the records and keywords from the VPD, including large keywords (Keywords that begin with a # and are > 255 bytes in length).
  • It relies on a runtime JSON configuration (see examples/inventory.json) to determine the D-Bus object path(s) that hold interfaces and properties representing the VPD for a given VPD file path.

Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.

TODOs and Future Improvements

  1. The long-term goal is to completely do away with the build time YAML driven configurations and instead reconcile the OpenPower VPD parser and the IBM VPD parser applications into a single runtime JSON driven application.
  2. Add details to the README on how to configure and build the application.
  3. More JSON documentation.
  4. Support for more IBM VPD formats.
  5. VPD Write and tool documentation.