tree e1f350ffb64c92979cfd91cc15e725e0d9d859d8
parent 269bff30da8dfabe84d29d6a510bf3b5fdb51fee
author Lei YU <mine260309@gmail.com> 1534836533 +0800
committer Lei YU <mine260309@gmail.com> 1535598185 +0000

Delete functional BMC id if ACTIVE_BMC_MAX_ALLOWED is less than 2

The current logic in ItemUpdater::freeSpace() will try to find the
non-functional BMC ids and remove extra ones as long as the active BMC
images is greater than ACTIVE_BMC_MAX_ALLOWED.

For static layout systems with only one BMC flash chip, the above logic
will cause an issue that the "old" BMC id not deleted during code
update, because the "old" BMC id is the functional one.

This commit changes the above logic, that if ACTIVE_BMC_MAX_ALLOWED is
less than 2 (e.g. 1), delete the functional BMC id as well, because
there really is only one BMC after all.

Partly resolves openbmc/phosphor-bmc-code-mgmt#2

Tested: Verify that the "old" BMC id is deleted during code update, if
        ACTIVE_BMC_MAX_ALLOWED is configured to 1, on Romulus.

Change-Id: I6f21b4269dd78d71f7e9181bb913c49b575321d1
Signed-off-by: Lei YU <mine260309@gmail.com>