tree d5d699079a4d12dedb1219f26e39b201475744a6
parent 4c3edc911ba880f7643f15679018c436aa94e0aa
author Adriana Kobylak <anoo@us.ibm.com> 1518474013 -0600
committer Adriana Kobylak <anoo@us.ibm.com> 1518557985 -0600

image_manager: Check if tmp dir exists before remove

There was an error seen where the version manager core dumped when
it tried to remove the temporary directory after a manifest failure:

phosphor-version-software-manager[1264]: Error No manifest file
phosphor-version-software-manager[1264]: terminate called after throwing an
    instance of 'std::experimental::filesystem::v1::__cxx11::filesystem_error'
phosphor-version-software-manager[1264]:   what():  filesystem error: cannot
    remove all: No such file or directory [/tmp/images/imageKcwJFc]

To prevent the core dump, check that the directory exists before trying
to remove it. Create a journal error entry to aid debug since path should
exist.

Change-Id: Ifb47f9a44aa8835c8b7416c7e1a0e67c664d6160
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>