commit 887ba5bf5fd89e83a80c5011027bcea4f134a0f2
author Ravi Teja <raviteja28031990@gmail.com> Wed Jun 19 04:37:31 2024 -0500
committer Ravi Teja <raviteja28031990@gmail.com> Wed Jun 19 18:04:45 2024 +0000
tree efb7b84ae2b1ac9f9a90c6e46bb73b47a38b10f6
parent 798dca541c5d582d43fc953b0768a5aa2b009be5

Test: Fix CI failure

Currently CI fails with --wrapper 'valgrind --error-exitcode=1'

This commit fixes few variables initialization in test code and increase
timeout to generate certs to 500 seconds considering valgrind enabled.

Tested by:
CI passed with --wrapper 'valgrind --error-exitcode=1'

Change-Id: I1bf26fb2fafbf68bcb128eb77083a99867dd21c8
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

test/certs_manager_test.cpp

diff --git a/test/certs_manager_test.cpp b/test/certs_manager_test.cpp
index 6d5149e..c44f7ec 100644
--- a/test/certs_manager_test.cpp
+++ b/test/certs_manager_test.cpp
@@ -207,7 +207,7 @@
     std::string certificateFile, CSRFile, privateKeyFile, rsaPrivateKeyFilePath;
 
     std::string certDir;
-    uint64_t certId;
+    uint64_t certId = 1;
 };
 
 class MainApp
@@ -1030,7 +1030,7 @@
     bus.attach_event(event.get(), SD_EVENT_PRIORITY_NORMAL);
     Manager manager(bus, event, objPath.c_str(), type, std::move(unit),
                     std::move(installPath));
-    Status status;
+    Status status = Status::success;
     CSR csr(bus, objPath.c_str(), csrPath.c_str(), status);
     MainApp mainApp(&manager, &csr);
     mainApp.generateCSR(alternativeNames, challengePassword, city, commonName,
@@ -1038,7 +1038,7 @@
                         keyBitLength, keyCurveId, keyPairAlgorithm, keyUsage,
                         organization, organizationalUnit, state, surname,
                         unstructuredName);
-    std::string csrData("");
+    std::string csrData{};
     // generateCSR takes considerable time to create CSR and privateKey Files
     EXPECT_FALSE(fs::exists(csrPath));
     EXPECT_FALSE(fs::exists(privateKeyPath));
@@ -1285,7 +1285,7 @@
     auto event = sdeventplus::Event::get_default();
     Manager manager(bus, event, objPath.c_str(), type, std::move(unit),
                     std::move(installPath));
-    Status status;
+    Status status = Status::success;
     CSR csr(bus, objPath.c_str(), csrPath.c_str(), status);
     MainApp mainApp(&manager, &csr);
     mainApp.generateCSR(alternativeNames, challengePassword, city, commonName,

test/meson.build

diff --git a/test/meson.build b/test/meson.build
index e2cc092..d90822b 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -45,7 +45,8 @@
             cert_manager_dep,
         ],
     ),
-    timeout: 360, # Takes about 1 minute to generate all the certs.  Allow 3x.
+    timeout: 500, # Takes about 1 minute to generate all the certs.
+                  # considering valgrind enabled path setting up this 500 sec.
 )
 
 if not get_option('ca-cert-extension').disabled()