commit 8a59ea28a9759d0b4e2ce7a996253fd7e2eb5302
author Jayanth Othayoth <ojayanth@gmail.com> Sun Nov 24 23:14:10 2024 -0600
committer Jayanth Othayoth <ojayanth@gmail.com> Mon Nov 25 08:26:51 2024 -0600
tree 3332736b37ad60ceb72e23f09e4df2760afcaab8
parent 1c1497a5d54311226494210a9e12e762ad6af729

clang-tidy: Enable bugprone-implicit-widening-of

Modified code to address issues flagged by
bugprone-implicit-widening-of-multiplication-result check.

Tested: Build and unit tests passed successfully.

Change-Id: I68bae8863c9e2d57154588bfda8c1e235637dffe
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

certificate.cpp

diff --git a/certificate.cpp b/certificate.cpp
index 5e4ef9c..0ff3ad5 100644
--- a/certificate.cpp
+++ b/certificate.cpp
@@ -549,7 +549,7 @@
     // Set time to 00:00am GMT, Jan 1 1970; format: YYYYMMDDHHMMSSZ
     ASN1_TIME_set_string(epoch.get(), "19700101000000Z");
 
-    static const uint64_t dayToSeconds = 24 * 60 * 60;
+    constexpr uint64_t dayToSeconds = 86400; // 24 * 60 * 60
     ASN1_TIME* notAfter = X509_get_notAfter(&cert);
     ASN1_TIME_diff(&days, &secs, epoch.get(), notAfter);
     validNotAfter((days * dayToSeconds) + secs);