clang-tidy: Enable bugprone-assignment-in-if

Modified code to address issues flagged by this check.

Tested: Build and unit tests passed successfully.

Change-Id: I3b5f7c29fa38fc39da06e27488d70866006695c9
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>
diff --git a/.clang-tidy b/.clang-tidy
index df0114b..3322c6f 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -2,6 +2,7 @@
 -*,
 bugprone-argument-comment,
 bugprone-assert-side-effect,
+bugprone-assignment-in-if,
 bugprone-bad-signal-to-kill-thread,
 bugprone-bool-pointer-implicit-conversion,
 bugprone-branch-clone,