commit ebd21ba4fc36577a70cad207e42d66594b73ed13
author Patrick Williams <patrick@stwcx.xyz> Tue Apr 05 14:58:53 2022 -0500
committer Patrick Williams <patrick@stwcx.xyz> Tue Apr 05 15:00:57 2022 -0500
tree c1d091f7974159da14a8b92b6bc7df8b9d66cd80
parent 7047be6784455faa71f16ebbc66a74040634e350

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications.  Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4137ab812650afc09073d7b110254de87d5e5710

bmc-vmi-ca/ca_cert_entry.hpp

diff --git a/bmc-vmi-ca/ca_cert_entry.hpp b/bmc-vmi-ca/ca_cert_entry.hpp
index 1b75fa4..a461632 100644
--- a/bmc-vmi-ca/ca_cert_entry.hpp
+++ b/bmc-vmi-ca/ca_cert_entry.hpp
@@ -48,7 +48,8 @@
     Entry(sdbusplus::bus::bus& bus, const std::string& objPath,
           uint32_t entryId, std::string& csr, std::string& cert,
           CACertMgr& manager) :
-        internal::EntryInterface(bus, objPath.c_str(), true),
+        internal::EntryInterface(bus, objPath.c_str(),
+                                 internal::EntryInterface::action::defer_emit),
         bus(bus), id(entryId), manager(manager)
 
     {

certificate.cpp

diff --git a/certificate.cpp b/certificate.cpp
index 419f626..f5e8ae9 100644
--- a/certificate.cpp
+++ b/certificate.cpp
@@ -232,7 +232,9 @@
                          CertificateType type, const std::string& installPath,
                          const std::string& uploadPath, Watch* watch,
                          Manager& parent) :
-    internal::CertificateInterface(bus, objPath.c_str(), true),
+    internal::CertificateInterface(
+        bus, objPath.c_str(),
+        internal::CertificateInterface::action::defer_emit),
     objectPath(objPath), certType(type), certInstallPath(installPath),
     certWatch(watch), manager(parent)
 {
@@ -269,7 +271,9 @@
                          const std::string& installPath, X509_STORE& x509Store,
                          const std::string& pem, Watch* watchPtr,
                          Manager& parent) :
-    internal::CertificateInterface(bus, objPath.c_str(), true),
+    internal::CertificateInterface(
+        bus, objPath.c_str(),
+        internal::CertificateInterface::action::defer_emit),
     objectPath(objPath), certType(type), certInstallPath(installPath),
     certWatch(watchPtr), manager(parent)
 {

csr.cpp

diff --git a/csr.cpp b/csr.cpp
index 9ba8f00..5b44c62 100644
--- a/csr.cpp
+++ b/csr.cpp
@@ -33,7 +33,8 @@
 
 CSR::CSR(sdbusplus::bus::bus& bus, const char* path, std::string&& installPath,
          const Status& status) :
-    internal::CSRInterface(bus, path, true),
+    internal::CSRInterface(bus, path,
+                           internal::CSRInterface::action::defer_emit),
     objectPath(path), certInstallPath(std::move(installPath)), csrStatus(status)
 {
     // Emit deferred signal.