Use createDump method to create different types of BMC dumps
There are two create interfaces for phosphor-debug-collector.
1- external create - this interface
Which accepts a list of key-value pairs as input,
but initially, this was not accepting any parameters.
2- A create interface in phosphor-debug-collector,
which accepts the type of the BMC dump and a set of
paths to dbus or files to collect as part of dump creation.
The internal create is called by core-monitor or ramoops monitor
to create BMC dump when the error has occurred, or a core is created,
and now there is a new requirement to pass error log id along with
these create calls.
The internal create is added to pass parameters, and the external
one is always assumed as user-initiated. Since now the createDump method
is accepting additional parameters, internal create can be removed
and both system-generated and user-initiated dumps can use the
same interface and method.
This commit adds the dump type and enumeration for the types,
additionally changing the path parameter from the array of strings
to a single string because only for the core dump, there is an attempt
to send multiple paths but that can be captured in the packaging script
if the folder is sent.
Change-Id: Icbeb8499fbdfc1f8919b571495a50867bdcecac1
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
diff --git a/yaml/xyz/openbmc_project/Dump/Create.interface.yaml b/yaml/xyz/openbmc_project/Dump/Create.interface.yaml
index bc43fe2..3b08b1f 100644
--- a/yaml/xyz/openbmc_project/Dump/Create.interface.yaml
+++ b/yaml/xyz/openbmc_project/Dump/Create.interface.yaml
@@ -61,3 +61,27 @@
Type of the originator that initiated the respective operation.
This property is defined in xyz.openbmc_project.
Common.OriginatedBy interface.
+ - name: "DumpType"
+ description: >
+ Type of the BMC dump to be collected
+ - name: "FilePath"
+ description: >
+ The path to a file to create the dump, for example a systemd
+ core-dump.
+
+ - name: DumpType
+ description: >
+ Possible types of BMC Dump.
+ values:
+ - name: "ApplicationCored"
+ description: >
+ Dump triggered due to application core.
+ - name: "UserRequested"
+ description: >
+ Dump triggered by the user.
+ - name: "InternalFailure"
+ description: >
+ Dump triggered due to InternalFailure type error commit.
+ - name: "Ramoops"
+ description: >
+ Dump triggered due to Ramoops type error commit.