Change the CapabilitiesFlags property into booleans
Each bit in CapabilitiesFlags dbus property is a chassis
capability. Setting a capability overwrites other capabilities.
Read-and-update of the property results in race condition/confusion.
To tackle this, added a boolean property for each of chassis
capability. The new properties will be read and updated in ipmi
command handling code.
The original CapabilitiesFlags property will be deprecated once the
changes are made to use new boolean properties in all the repos.
Tested:
Tested this code along with the changes in ipmi-host to use these
new properties.
root@intel-obmc:~# ipmitool raw 0x00 0x00
07 22 44 66 88 aa
Signed-off-by: Karthick Sundarrajan <karthick.sundarrajan@intel.com>
Change-Id: I4d7f416749ee23f0843e87db5f39683c23f7c004
diff --git a/xyz/openbmc_project/Control/ChassisCapabilities.interface.yaml b/xyz/openbmc_project/Control/ChassisCapabilities.interface.yaml
index 2bfe620..3ea57ab 100644
--- a/xyz/openbmc_project/Control/ChassisCapabilities.interface.yaml
+++ b/xyz/openbmc_project/Control/ChassisCapabilities.interface.yaml
@@ -4,8 +4,26 @@
- name: CapabilitiesFlags
type: byte
description: >
+ Note: Please use the individual bit fields for Capabilities Flags
+ going forward. This common byte representation is deprecated.
Chassis capabilities flags. bit1= Provides front panel lockout,
bit0 = Provides intrusion. All other bits reserved.
+ - name: ChassisIntrusionEnabled
+ type: boolean
+ description: >
+ Chassis Provides intrusion (physical security) sensor.
+ - name: ChassisFrontPanelLockoutEnabled
+ type: boolean
+ description: >
+ Chassis Provides front panel lockout.
+ - name: ChassisNMIEnabled
+ type: boolean
+ description: >
+ Chassis Provides Diagnostic Interrupt (FP NMI).
+ - name: ChassisPowerInterlockEnabled
+ type: boolean
+ description: >
+ Chassis Provides Power Interlock.
- name: FRUDeviceAddress
type: byte
description: >