Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-debug-collector / 0007b70ca1d59c2349224b5d4ad5aba39560b668
commit0007b70ca1d59c2349224b5d4ad5aba39560b668[log] [tgz]
authorDhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>Tue Feb 01 03:23:14 2022 -0600
committerDhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>Tue Jun 13 22:06:14 2023 -0500
treef5589cf3415a0f156c67c09d2d2641d0e440ac01
parentd1f670fe7ea219c643f8b630e8c2d7b333f16e35 [diff]
OpenPOWER: Ignore duplicate system dump entry

This commit introduces changes to handle scenarios where
the host might report the same system dump entry more than once.
The changes have been made to address two main scenarios:

When the host generates a system dump having the same dump id
and size as an existing entry, the new notification is ignored
if the existing entry is marked as 'completed'. A trace is added
if the existing entry is incomplete.

In cases where the dump id matches an existing entry, but the size
is different, the old entry is considered stale and gets deleted.
A new entry will be created subsequently.

This issue arises particularly during internal failure recovery
in the host, where it notifies all the pending dumps again.
In cases where entries are already available for such dumps on the BMC,
duplicate entries may be created, potentially leading to confusion
for users. This change prevents the creation of new entries if an entry
already exists for the same dump.

Tests:
Create a disruptive system dump and offload
Create a non-disruptive system dump and offload

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I31d92df43476a19880d084a68e5db17c5207bd81
1 file changed
tree: f5589cf3415a0f156c67c09d2d2641d0e440ac01
  1. dump-extensions/
  2. host-transport-extensions/
  3. subprojects/
  4. test/
  5. tools/
  6. xyz/
  7. .clang-format
  8. .gitignore
  9. .shellcheck-ignore
  10. bmc_dump_entry.cpp
  11. bmc_dump_entry.hpp
  12. core_manager.cpp
  13. core_manager.hpp
  14. core_manager_main.cpp
  15. dump-extensions.hpp
  16. dump_entry.cpp
  17. dump_entry.hpp
  18. dump_internal.hpp
  19. dump_manager.cpp
  20. dump_manager.hpp
  21. dump_manager_bmc.cpp
  22. dump_manager_bmc.hpp
  23. dump_manager_faultlog.cpp
  24. dump_manager_faultlog.hpp
  25. dump_manager_main.cpp
  26. dump_offload.cpp
  27. dump_offload.hpp
  28. dump_serialize.cpp
  29. dump_serialize.hpp
  30. dump_utils.cpp
  31. dump_utils.hpp
  32. elog_watch.cpp
  33. elog_watch.hpp
  34. errors_map.mako.hpp
  35. errors_map_gen.py
  36. example_errors_watch.yaml
  37. faultlog_dump_entry.cpp
  38. faultlog_dump_entry.hpp
  39. ffdc
  40. host_transport_exts.hpp
  41. LICENSE
  42. meson.build
  43. meson_options.txt
  44. OWNERS
  45. ramoops_manager.cpp
  46. ramoops_manager.hpp
  47. ramoops_manager_main.cpp
  48. README.md
  49. watch.cpp
  50. watch.hpp
README.md

phosphor-debug-collector

Phosphor Debug Collector provides mechanisms to collect various log files and system parameters. Used to troubleshoot problems in OpenBMC based systems.

One such mechanism is dreport, a script that collects debug data and packages it into an archive file.

To Build

To build this package with meson, do the following steps:

    1. meson builddir
    2. ninja -C builddir

To clean the built files run ninja -C builddir clean.

To run unit tests

Tests can be run in the CI docker container, refer local-ci-build

or with an OpenBMC x86 sdk(see below for x86 steps).

meson -Dtests=enabled build
ninja -C build test