commit 109e9948e23279e5821572c7806bf5a845b2283b
author Jayanth Othayoth <ojayanth@gmail.com> Mon Nov 25 10:30:43 2024 -0600
committer Jayanth Othayoth <ojayanth@gmail.com> Mon Nov 25 10:41:05 2024 -0600
tree a4de549aa7618314e33d198da540f3b5df42fa0f
parent 508113afe1a6585e8bb05ce8925531383a68e9d5

clang-tidy: Enable bugprone-forward-declaration

Modified code to address issues flagged by
bugprone-forward-declaration-namespace check.

Tested: Build and unit tests passed successfully.

Change-Id: Ied7e54a6aa30d3f8110bcd7036c84b99e7fe6fb8
Signed-off-by: Jayanth Othayoth <ojayanth@gmail.com>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 80de2f6..bfa78f0 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -13,6 +13,7 @@
 bugprone-dangling-handle,
 bugprone-dynamic-static-initializers,
 bugprone-fold-init-type,
+bugprone-forward-declaration-namespace,
 bugprone-forwarding-reference-overload,
 bugprone-implicit-widening-of-multiplication-result,
 bugprone-inaccurate-erase,

bmc_dump_entry.hpp

diff --git a/bmc_dump_entry.hpp b/bmc_dump_entry.hpp
index 58d9702..63ae4c5 100644
--- a/bmc_dump_entry.hpp
+++ b/bmc_dump_entry.hpp
@@ -26,8 +26,6 @@
 using originatorTypes = sdbusplus::xyz::openbmc_project::Common::server::
     OriginatedBy::OriginatorTypes;
 
-class Manager;
-
 /** @class Entry
  *  @brief OpenBMC Dump Entry implementation.
  *  @details A concrete implementation for the

faultlog_dump_entry.hpp

diff --git a/faultlog_dump_entry.hpp b/faultlog_dump_entry.hpp
index 3e5b53a..44fcfc6 100644
--- a/faultlog_dump_entry.hpp
+++ b/faultlog_dump_entry.hpp
@@ -18,8 +18,6 @@
 template <typename T>
 using ServerObject = typename sdbusplus::server::object_t<T>;
 
-class Manager;
-
 /** @class Entry
  *  @brief OpenBMC Fault Log Dump Entry implementation.
  */