commit 1112bdfc68fb4cb5ec58d42175d2896a27dd917a
author Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> Wed Mar 23 04:38:02 2022 -0500
committer Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> Wed Oct 12 05:40:53 2022 -0500
tree 0fc4c15eede042dab402121077fb76dcfb1764dc
parent a5097b9e88ffda487c286d846a71c1f617389c90

OpenPOWER: Prevent dump delete while offloading

Prevent the deletion of the dumps stored in host memory
while offload is in progress

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I053d802a96548fdd9240cf21ef2bf91c4b38e367

dump-extensions/openpower-dumps/resource_dump_entry.cpp

diff --git a/dump-extensions/openpower-dumps/resource_dump_entry.cpp b/dump-extensions/openpower-dumps/resource_dump_entry.cpp
index 692ec14..40fa909 100644
--- a/dump-extensions/openpower-dumps/resource_dump_entry.cpp
+++ b/dump-extensions/openpower-dumps/resource_dump_entry.cpp
@@ -46,6 +46,19 @@
 {
     auto srcDumpID = sourceDumpId();
     auto dumpId = id;
+
+    if ((!offloadUri().empty()) && (phosphor::dump::isHostRunning()))
+    {
+        log<level::ERR>(
+            fmt::format("Dump offload is in progress, cannot delete "
+                        "dump, id({}) srcdumpid({})",
+                        dumpId, srcDumpID)
+                .c_str());
+        elog<sdbusplus::xyz::openbmc_project::Common::Error::NotAllowed>(
+            xyz::openbmc_project::Common::NotAllowed::REASON(
+                "Dump offload is in progress"));
+    }
+
     log<level::INFO>(fmt::format("Resource dump delete id({}) srcdumpid({})",
                                  dumpId, srcDumpID)
                          .c_str());

dump-extensions/openpower-dumps/system_dump_entry.cpp

diff --git a/dump-extensions/openpower-dumps/system_dump_entry.cpp b/dump-extensions/openpower-dumps/system_dump_entry.cpp
index fe313d4..2f44d34 100644
--- a/dump-extensions/openpower-dumps/system_dump_entry.cpp
+++ b/dump-extensions/openpower-dumps/system_dump_entry.cpp
@@ -36,6 +36,18 @@
 {
     auto srcDumpID = sourceDumpId();
     auto dumpId = id;
+
+    if ((!offloadUri().empty()) && (phosphor::dump::isHostRunning()))
+    {
+        log<level::ERR>(
+            fmt::format("Dump offload is in progress id({}) srcdumpid({})",
+                        dumpId, srcDumpID)
+                .c_str());
+        elog<sdbusplus::xyz::openbmc_project::Common::Error::NotAllowed>(
+            xyz::openbmc_project::Common::NotAllowed::REASON(
+                "Dump offload is in progress"));
+    }
+
     log<level::INFO>(fmt::format("System dump delete id({}) srcdumpid({})",
                                  dumpId, srcDumpID)
                          .c_str());