Fix clang-tidy linter and format issues
openbmc-build-scripts introduces clang-tidy-config linter.
Also fix the issues found by clang-tidy.
Change-Id: Ia37f740b110d0aca53e7608db03f12065468e3fb
Signed-off-by: Lei YU <yulei.sh@bytedance.com>
diff --git a/.clang-tidy b/.clang-tidy
index 44ad8ad..8bfef56 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,347 +1,351 @@
-Checks: '
--*,
-bugprone-argument-comment,
-bugprone-assert-side-effect,
-bugprone-assignment-in-if,
-bugprone-bad-signal-to-kill-thread,
-bugprone-bool-pointer-implicit-conversion,
-bugprone-branch-clone,
-bugprone-casting-through-void,
-bugprone-chained-comparison,
-bugprone-compare-pointer-to-member-virtual-function,
-bugprone-copy-constructor-init,
-bugprone-dangling-handle,
-bugprone-dynamic-static-initializers,
-bugprone-empty-catch,
-bugprone-fold-init-type,
-bugprone-forward-declaration-namespace,
-bugprone-forwarding-reference-overload,
-bugprone-implicit-widening-of-multiplication-result,
-bugprone-inaccurate-erase,
-bugprone-inc-dec-in-conditions,
-bugprone-incorrect-enable-if,
-bugprone-incorrect-roundings,
-bugprone-infinite-loop,
-bugprone-integer-division,
-bugprone-lambda-function-name,
-bugprone-macro-parentheses,
-bugprone-macro-repeated-side-effects,
-bugprone-misplaced-operator-in-strlen-in-alloc,
-bugprone-misplaced-pointer-arithmetic-in-alloc,
-bugprone-misplaced-widening-cast,
-bugprone-move-forwarding-reference,
-bugprone-multi-level-implicit-pointer-conversion,
-bugprone-multiple-new-in-one-expression,
-bugprone-multiple-statement-macro,
-bugprone-narrowing-conversions,
-bugprone-no-escape,
-bugprone-non-zero-enum-to-bool-conversion,
-bugprone-not-null-terminated-result,
-bugprone-optional-value-conversion,
-bugprone-parent-virtual-call,
-bugprone-posix-return,
-bugprone-redundant-branch-condition,
-bugprone-reserved-identifier,
-bugprone-shared-ptr-array-mismatch,
-bugprone-signal-handler,
-bugprone-signed-char-misuse,
-bugprone-sizeof-container,
-bugprone-sizeof-expression,
-bugprone-spuriously-wake-up-functions,
-bugprone-standalone-empty,
-bugprone-string-constructor,
-bugprone-string-integer-assignment,
-bugprone-string-literal-with-embedded-nul,
-bugprone-stringview-nullptr,
-bugprone-suspicious-enum-usage,
-bugprone-suspicious-include,
-bugprone-suspicious-memory-comparison,
-bugprone-suspicious-memset-usage,
-bugprone-suspicious-missing-comma,
-bugprone-suspicious-realloc-usage,
-bugprone-suspicious-semicolon,
-bugprone-suspicious-string-compare,
-bugprone-swapped-arguments,
-bugprone-switch-missing-default-case,
-bugprone-terminating-continue,
-bugprone-throw-keyword-missing,
-bugprone-too-small-loop-variable,
-bugprone-unchecked-optional-access,
-bugprone-undefined-memory-manipulation,
-bugprone-undelegated-constructor,
-bugprone-unhandled-exception-at-new,
-bugprone-unhandled-self-assignment,
-bugprone-unique-ptr-array-mismatch,
-bugprone-unsafe-functions,
-bugprone-unused-local-non-trivial-variable,
-bugprone-unused-raii,
-bugprone-unused-return-value,
-bugprone-use-after-move,
-bugprone-virtual-near-miss,
-cert-con36-c,
-cert-con54-cpp,
-cert-dcl03-c,
-cert-dcl16-c,
-cert-dcl21-cpp,
-cert-dcl37-c,
-cert-dcl50-cpp,
-cert-dcl51-cpp,
-cert-dcl54-cpp,
-cert-dcl58-cpp,
-cert-dcl59-cpp,
-cert-env33-c,
-cert-err09-cpp,
-cert-err34-c,
-cert-err52-cpp,
-cert-err60-cpp,
-cert-err61-cpp,
-cert-fio38-c,
-cert-flp30-c,
-cert-mem57-cpp,
-cert-msc30-c,
-cert-msc32-c,
-cert-msc50-cpp,
-cert-msc51-cpp,
-cert-oop11-cpp,
-cert-oop54-cpp,
-cert-oop57-cpp,
-cert-oop58-cpp,
-cert-pos44-c,
-cert-pos47-c,
-cert-sig30-c,
-cert-str34-c,
-clang-analyzer-apiModeling.Errno,
-clang-analyzer-apiModeling.TrustNonnull,
-clang-analyzer-apiModeling.TrustReturnsNonnull,
-clang-analyzer-apiModeling.google.GTest,
-clang-analyzer-apiModeling.llvm.CastValue,
-clang-analyzer-apiModeling.llvm.ReturnValue,
-clang-analyzer-core.BitwiseShift,
-clang-analyzer-core.CallAndMessage,
-clang-analyzer-core.CallAndMessageModeling,
-clang-analyzer-core.DivideZero,
-clang-analyzer-core.DynamicTypePropagation,
-clang-analyzer-core.NonNullParamChecker,
-clang-analyzer-core.NonnilStringConstants,
-clang-analyzer-core.NullDereference,
-clang-analyzer-core.StackAddrEscapeBase,
-clang-analyzer-core.StackAddressEscape,
-clang-analyzer-core.UndefinedBinaryOperatorResult,
-clang-analyzer-core.VLASize,
-clang-analyzer-core.builtin.BuiltinFunctions,
-clang-analyzer-core.builtin.NoReturnFunctions,
-clang-analyzer-core.uninitialized.ArraySubscript,
-clang-analyzer-core.uninitialized.Assign,
-clang-analyzer-core.uninitialized.Branch,
-clang-analyzer-core.uninitialized.CapturedBlockVariable,
-clang-analyzer-core.uninitialized.NewArraySize,
-clang-analyzer-core.uninitialized.UndefReturn,
-clang-analyzer-cplusplus.InnerPointer,
-clang-analyzer-cplusplus.Move,
-clang-analyzer-cplusplus.NewDelete,
-clang-analyzer-cplusplus.NewDeleteLeaks,
-clang-analyzer-cplusplus.PlacementNew,
-clang-analyzer-cplusplus.PureVirtualCall,
-clang-analyzer-cplusplus.SelfAssignment,
-clang-analyzer-cplusplus.SmartPtrModeling,
-clang-analyzer-cplusplus.StringChecker,
-clang-analyzer-cplusplus.VirtualCallModeling,
-clang-analyzer-deadcode.DeadStores,
-clang-analyzer-fuchsia.HandleChecker,
-clang-analyzer-nullability.NullPassedToNonnull,
-clang-analyzer-nullability.NullReturnedFromNonnull,
-clang-analyzer-nullability.NullabilityBase,
-clang-analyzer-nullability.NullableDereferenced,
-clang-analyzer-nullability.NullablePassedToNonnull,
-clang-analyzer-nullability.NullableReturnedFromNonnull,
-clang-analyzer-optin.core.EnumCastOutOfRange,
-clang-analyzer-optin.cplusplus.UninitializedObject,
-clang-analyzer-optin.cplusplus.VirtualCall,
-clang-analyzer-optin.mpi.MPI-Checker,
-clang-analyzer-optin.osx.OSObjectCStyleCast,
-clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
-clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,
-clang-analyzer-optin.performance.GCDAntipattern,
-clang-analyzer-optin.performance.Padding,
-clang-analyzer-optin.portability.UnixAPI,
-clang-analyzer-osx.API,
-clang-analyzer-osx.MIG,
-clang-analyzer-osx.NSOrCFErrorDerefChecker,
-clang-analyzer-osx.NumberObjectConversion,
-clang-analyzer-osx.OSObjectRetainCount,
-clang-analyzer-osx.ObjCProperty,
-clang-analyzer-osx.SecKeychainAPI,
-clang-analyzer-osx.cocoa.AtSync,
-clang-analyzer-osx.cocoa.AutoreleaseWrite,
-clang-analyzer-osx.cocoa.ClassRelease,
-clang-analyzer-osx.cocoa.Dealloc,
-clang-analyzer-osx.cocoa.IncompatibleMethodTypes,
-clang-analyzer-osx.cocoa.Loops,
-clang-analyzer-osx.cocoa.MissingSuperCall,
-clang-analyzer-osx.cocoa.NSAutoreleasePool,
-clang-analyzer-osx.cocoa.NSError,
-clang-analyzer-osx.cocoa.NilArg,
-clang-analyzer-osx.cocoa.NonNilReturnValue,
-clang-analyzer-osx.cocoa.ObjCGenerics,
-clang-analyzer-osx.cocoa.RetainCount,
-clang-analyzer-osx.cocoa.RetainCountBase,
-clang-analyzer-osx.cocoa.RunLoopAutoreleaseLeak,
-clang-analyzer-osx.cocoa.SelfInit,
-clang-analyzer-osx.cocoa.SuperDealloc,
-clang-analyzer-osx.cocoa.UnusedIvars,
-clang-analyzer-osx.cocoa.VariadicMethodTypes,
-clang-analyzer-osx.coreFoundation.CFError,
-clang-analyzer-osx.coreFoundation.CFNumber,
-clang-analyzer-osx.coreFoundation.CFRetainRelease,
-clang-analyzer-osx.coreFoundation.containers.OutOfBounds,
-clang-analyzer-osx.coreFoundation.containers.PointerSizedValues,
-clang-analyzer-security.FloatLoopCounter,
-clang-analyzer-security.cert.env.InvalidPtr,
-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
-clang-analyzer-security.insecureAPI.SecuritySyntaxChecker,
-clang-analyzer-security.insecureAPI.UncheckedReturn,
-clang-analyzer-security.insecureAPI.bcmp,
-clang-analyzer-security.insecureAPI.bcopy,
-clang-analyzer-security.insecureAPI.bzero,
-clang-analyzer-security.insecureAPI.decodeValueOfObjCType,
-clang-analyzer-security.insecureAPI.getpw,
-clang-analyzer-security.insecureAPI.gets,
-clang-analyzer-security.insecureAPI.mkstemp,
-clang-analyzer-security.insecureAPI.mktemp,
-clang-analyzer-security.insecureAPI.rand,
-clang-analyzer-security.insecureAPI.strcpy,
-clang-analyzer-security.insecureAPI.vfork,
-clang-analyzer-unix.API,
-clang-analyzer-unix.DynamicMemoryModeling,
-clang-analyzer-unix.Errno,
-clang-analyzer-unix.Malloc,
-clang-analyzer-unix.MallocSizeof,
-clang-analyzer-unix.MismatchedDeallocator,
-clang-analyzer-unix.StdCLibraryFunctions,
-clang-analyzer-unix.Vfork,
-clang-analyzer-unix.cstring.BadSizeArg,
-clang-analyzer-unix.cstring.CStringModeling,
-clang-analyzer-unix.cstring.NullArg,
-clang-analyzer-valist.CopyToSelf,
-clang-analyzer-valist.Uninitialized,
-clang-analyzer-valist.Unterminated,
-clang-analyzer-valist.ValistBase,
-clang-analyzer-webkit.NoUncountedMemberChecker,
-clang-analyzer-webkit.RefCntblBaseVirtualDtor,
-clang-analyzer-webkit.UncountedLambdaCapturesChecker,
-cppcoreguidelines-avoid-capturing-lambda-coroutines,
-cppcoreguidelines-avoid-goto,
-cppcoreguidelines-avoid-reference-coroutine-parameters,
-cppcoreguidelines-c-copy-assignment-signature,
-cppcoreguidelines-interfaces-global-init,
-cppcoreguidelines-misleading-capture-default-by-value,
-cppcoreguidelines-narrowing-conversions,
-cppcoreguidelines-no-malloc,
-cppcoreguidelines-no-suspend-with-lock,
-cppcoreguidelines-noexcept-destructor,
-cppcoreguidelines-noexcept-move-operations,
-cppcoreguidelines-noexcept-swap,
-cppcoreguidelines-prefer-member-initializer,
-cppcoreguidelines-pro-bounds-array-to-pointer-decay,
-cppcoreguidelines-pro-type-const-cast,
-cppcoreguidelines-pro-type-static-cast-downcast,
-cppcoreguidelines-pro-type-union-access,
-cppcoreguidelines-rvalue-reference-param-not-moved,
-cppcoreguidelines-use-default-member-init,
-cppcoreguidelines-virtual-class-destructor,
-cppcoreguidelines-slicing,
-cppcoreguidelines-special-member-functions,
-misc-coroutine-hostile-raii,
-misc-header-include-cycle,
-misc-misleading-bidirectional,
-misc-misleading-identifier,
-misc-misplaced-const,
-misc-new-delete-overloads,
-misc-non-copyable-objects,
-misc-redundant-expression,
-misc-static-assert,
-misc-throw-by-value-catch-by-reference,
-misc-unconventional-assign-operator,
-misc-uniqueptr-reset-release,
-misc-unused-alias-decls,
-misc-unused-parameters,
-misc-unused-using-decls,
-modernize-deprecated-headers,
-modernize-deprecated-ios-base-aliases,
-modernize-loop-convert,
-modernize-make-shared,
-modernize-make-unique,
-modernize-raw-string-literal,
-modernize-redundant-void-arg,
-modernize-replace-auto-ptr,
-modernize-replace-random-shuffle,
-modernize-return-braced-init-list,
-modernize-shrink-to-fit,
-modernize-unary-static-assert,
-modernize-use-bool-literals,
-modernize-use-default-member-init,
-modernize-use-emplace,
-modernize-use-equals-default,
-modernize-use-equals-delete,
-modernize-use-noexcept,
-modernize-use-starts-ends-with,
-modernize-use-std-numbers,
-modernize-use-transparent-functors,
-modernize-use-uncaught-exceptions,
-performance-faster-string-find,
-performance-for-range-copy,
-performance-implicit-conversion-in-loop,
-performance-inefficient-algorithm,
-performance-inefficient-string-concatenation,
-performance-inefficient-vector-operation,
-performance-move-const-arg,
-performance-move-constructor-init,
-performance-no-automatic-move,
-performance-no-int-to-ptr,
-performance-noexcept-destructor,
-performance-noexcept-move-constructor,
-performance-noexcept-swap,
-performance-trivially-destructible,
-performance-type-promotion-in-math-fn,
-performance-unnecessary-copy-initialization,
-readability-avoid-const-params-in-decls,
-readability-avoid-nested-conditional-operator,
-readability-avoid-return-with-void-value,
-readability-avoid-unconditional-preprocessor-if,
-readability-braces-around-statements,
-readability-const-return-type,
-readability-container-contains,
-readability-container-data-pointer,
-readability-delete-null-pointer,
-readability-duplicate-include,
-readability-deleted-default,
-readability-function-size,
-readability-identifier-naming,
-readability-implicit-bool-conversion
-readability-isolate-declaration,
-readability-misleading-indentation,
-readability-misplaced-array-index,
-readability-operators-representation,
-readability-non-const-parameter,
-readability-redundant-access-specifiers,
-readability-redundant-casting,
-readability-redundant-declaration,
-readability-redundant-function-ptr-dereference,
-readability-redundant-member-init,
-readability-redundant-preprocessor,
-readability-redundant-smartptr-get,
-readability-redundant-string-init,
-readability-reference-to-constructed-temporary,
-readability-simplify-subscript-expr,
-readability-static-definition-in-anonymous-namespace,
-readability-string-compare,
-readability-uniqueptr-delete-release,
-readability-uppercase-literal-suffix'
-
-WarningsAsErrors: '*'
-HeaderFilterRegex: '(?!^subprojects).*'
+Checks: '-*,
+ bugprone-argument-comment,
+ bugprone-assert-side-effect,
+ bugprone-assignment-in-if,
+ bugprone-bad-signal-to-kill-thread,
+ bugprone-bool-pointer-implicit-conversion,
+ bugprone-branch-clone,
+ bugprone-casting-through-void,
+ bugprone-chained-comparison,
+ bugprone-compare-pointer-to-member-virtual-function,
+ bugprone-copy-constructor-init,
+ bugprone-dangling-handle,
+ bugprone-dynamic-static-initializers,
+ bugprone-empty-catch,
+ bugprone-fold-init-type,
+ bugprone-forward-declaration-namespace,
+ bugprone-forwarding-reference-overload,
+ bugprone-implicit-widening-of-multiplication-result,
+ bugprone-inaccurate-erase,
+ bugprone-inc-dec-in-conditions,
+ bugprone-incorrect-enable-if,
+ bugprone-incorrect-roundings,
+ bugprone-infinite-loop,
+ bugprone-integer-division,
+ bugprone-lambda-function-name,
+ bugprone-macro-parentheses,
+ bugprone-macro-repeated-side-effects,
+ bugprone-misplaced-operator-in-strlen-in-alloc,
+ bugprone-misplaced-pointer-arithmetic-in-alloc,
+ bugprone-misplaced-widening-cast,
+ bugprone-move-forwarding-reference,
+ bugprone-multi-level-implicit-pointer-conversion,
+ bugprone-multiple-new-in-one-expression,
+ bugprone-multiple-statement-macro,
+ bugprone-narrowing-conversions,
+ bugprone-no-escape,
+ bugprone-non-zero-enum-to-bool-conversion,
+ bugprone-not-null-terminated-result,
+ bugprone-optional-value-conversion,
+ bugprone-parent-virtual-call,
+ bugprone-posix-return,
+ bugprone-redundant-branch-condition,
+ bugprone-reserved-identifier,
+ bugprone-shared-ptr-array-mismatch,
+ bugprone-signal-handler,
+ bugprone-signed-char-misuse,
+ bugprone-sizeof-container,
+ bugprone-sizeof-expression,
+ bugprone-spuriously-wake-up-functions,
+ bugprone-standalone-empty,
+ bugprone-string-constructor,
+ bugprone-string-integer-assignment,
+ bugprone-string-literal-with-embedded-nul,
+ bugprone-stringview-nullptr,
+ bugprone-suspicious-enum-usage,
+ bugprone-suspicious-include,
+ bugprone-suspicious-memory-comparison,
+ bugprone-suspicious-memset-usage,
+ bugprone-suspicious-missing-comma,
+ bugprone-suspicious-realloc-usage,
+ bugprone-suspicious-semicolon,
+ bugprone-suspicious-string-compare,
+ bugprone-swapped-arguments,
+ bugprone-switch-missing-default-case,
+ bugprone-terminating-continue,
+ bugprone-throw-keyword-missing,
+ bugprone-too-small-loop-variable,
+ bugprone-unchecked-optional-access,
+ bugprone-undefined-memory-manipulation,
+ bugprone-undelegated-constructor,
+ bugprone-unhandled-exception-at-new,
+ bugprone-unhandled-self-assignment,
+ bugprone-unique-ptr-array-mismatch,
+ bugprone-unsafe-functions,
+ bugprone-unused-local-non-trivial-variable,
+ bugprone-unused-raii,
+ bugprone-unused-return-value,
+ bugprone-use-after-move,
+ bugprone-virtual-near-miss,
+ cert-con36-c,
+ cert-con54-cpp,
+ cert-dcl03-c,
+ cert-dcl16-c,
+ cert-dcl21-cpp,
+ cert-dcl37-c,
+ cert-dcl50-cpp,
+ cert-dcl51-cpp,
+ cert-dcl54-cpp,
+ cert-dcl58-cpp,
+ cert-dcl59-cpp,
+ cert-env33-c,
+ cert-err09-cpp,
+ cert-err34-c,
+ cert-err52-cpp,
+ cert-err60-cpp,
+ cert-err61-cpp,
+ cert-fio38-c,
+ cert-flp30-c,
+ cert-mem57-cpp,
+ cert-msc30-c,
+ cert-msc32-c,
+ cert-msc50-cpp,
+ cert-msc51-cpp,
+ cert-oop11-cpp,
+ cert-oop54-cpp,
+ cert-oop57-cpp,
+ cert-oop58-cpp,
+ cert-pos44-c,
+ cert-pos47-c,
+ cert-sig30-c,
+ cert-str34-c,
+ clang-analyzer-apiModeling.Errno,
+ clang-analyzer-apiModeling.TrustNonnull,
+ clang-analyzer-apiModeling.TrustReturnsNonnull,
+ clang-analyzer-apiModeling.google.GTest,
+ clang-analyzer-apiModeling.llvm.CastValue,
+ clang-analyzer-apiModeling.llvm.ReturnValue,
+ clang-analyzer-core.BitwiseShift,
+ clang-analyzer-core.CallAndMessage,
+ clang-analyzer-core.CallAndMessageModeling,
+ clang-analyzer-core.DivideZero,
+ clang-analyzer-core.DynamicTypePropagation,
+ clang-analyzer-core.NonNullParamChecker,
+ clang-analyzer-core.NonnilStringConstants,
+ clang-analyzer-core.NullDereference,
+ clang-analyzer-core.StackAddrEscapeBase,
+ clang-analyzer-core.StackAddressEscape,
+ clang-analyzer-core.UndefinedBinaryOperatorResult,
+ clang-analyzer-core.VLASize,
+ clang-analyzer-core.builtin.BuiltinFunctions,
+ clang-analyzer-core.builtin.NoReturnFunctions,
+ clang-analyzer-core.uninitialized.ArraySubscript,
+ clang-analyzer-core.uninitialized.Assign,
+ clang-analyzer-core.uninitialized.Branch,
+ clang-analyzer-core.uninitialized.CapturedBlockVariable,
+ clang-analyzer-core.uninitialized.NewArraySize,
+ clang-analyzer-core.uninitialized.UndefReturn,
+ clang-analyzer-cplusplus.InnerPointer,
+ clang-analyzer-cplusplus.Move,
+ clang-analyzer-cplusplus.NewDelete,
+ clang-analyzer-cplusplus.NewDeleteLeaks,
+ clang-analyzer-cplusplus.PlacementNew,
+ clang-analyzer-cplusplus.PureVirtualCall,
+ clang-analyzer-cplusplus.SelfAssignment,
+ clang-analyzer-cplusplus.SmartPtrModeling,
+ clang-analyzer-cplusplus.StringChecker,
+ clang-analyzer-cplusplus.VirtualCallModeling,
+ clang-analyzer-deadcode.DeadStores,
+ clang-analyzer-fuchsia.HandleChecker,
+ clang-analyzer-nullability.NullPassedToNonnull,
+ clang-analyzer-nullability.NullReturnedFromNonnull,
+ clang-analyzer-nullability.NullabilityBase,
+ clang-analyzer-nullability.NullableDereferenced,
+ clang-analyzer-nullability.NullablePassedToNonnull,
+ clang-analyzer-nullability.NullableReturnedFromNonnull,
+ clang-analyzer-optin.core.EnumCastOutOfRange,
+ clang-analyzer-optin.cplusplus.UninitializedObject,
+ clang-analyzer-optin.cplusplus.VirtualCall,
+ clang-analyzer-optin.mpi.MPI-Checker,
+ clang-analyzer-optin.osx.OSObjectCStyleCast,
+ clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
+ clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,
+ clang-analyzer-optin.performance.GCDAntipattern,
+ clang-analyzer-optin.performance.Padding,
+ clang-analyzer-optin.portability.UnixAPI,
+ clang-analyzer-osx.API,
+ clang-analyzer-osx.MIG,
+ clang-analyzer-osx.NSOrCFErrorDerefChecker,
+ clang-analyzer-osx.NumberObjectConversion,
+ clang-analyzer-osx.OSObjectRetainCount,
+ clang-analyzer-osx.ObjCProperty,
+ clang-analyzer-osx.SecKeychainAPI,
+ clang-analyzer-osx.cocoa.AtSync,
+ clang-analyzer-osx.cocoa.AutoreleaseWrite,
+ clang-analyzer-osx.cocoa.ClassRelease,
+ clang-analyzer-osx.cocoa.Dealloc,
+ clang-analyzer-osx.cocoa.IncompatibleMethodTypes,
+ clang-analyzer-osx.cocoa.Loops,
+ clang-analyzer-osx.cocoa.MissingSuperCall,
+ clang-analyzer-osx.cocoa.NSAutoreleasePool,
+ clang-analyzer-osx.cocoa.NSError,
+ clang-analyzer-osx.cocoa.NilArg,
+ clang-analyzer-osx.cocoa.NonNilReturnValue,
+ clang-analyzer-osx.cocoa.ObjCGenerics,
+ clang-analyzer-osx.cocoa.RetainCount,
+ clang-analyzer-osx.cocoa.RetainCountBase,
+ clang-analyzer-osx.cocoa.RunLoopAutoreleaseLeak,
+ clang-analyzer-osx.cocoa.SelfInit,
+ clang-analyzer-osx.cocoa.SuperDealloc,
+ clang-analyzer-osx.cocoa.UnusedIvars,
+ clang-analyzer-osx.cocoa.VariadicMethodTypes,
+ clang-analyzer-osx.coreFoundation.CFError,
+ clang-analyzer-osx.coreFoundation.CFNumber,
+ clang-analyzer-osx.coreFoundation.CFRetainRelease,
+ clang-analyzer-osx.coreFoundation.containers.OutOfBounds,
+ clang-analyzer-osx.coreFoundation.containers.PointerSizedValues,
+ clang-analyzer-security.FloatLoopCounter,
+ clang-analyzer-security.cert.env.InvalidPtr,
+ clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
+ clang-analyzer-security.insecureAPI.SecuritySyntaxChecker,
+ clang-analyzer-security.insecureAPI.UncheckedReturn,
+ clang-analyzer-security.insecureAPI.bcmp,
+ clang-analyzer-security.insecureAPI.bcopy,
+ clang-analyzer-security.insecureAPI.bzero,
+ clang-analyzer-security.insecureAPI.decodeValueOfObjCType,
+ clang-analyzer-security.insecureAPI.getpw,
+ clang-analyzer-security.insecureAPI.gets,
+ clang-analyzer-security.insecureAPI.mkstemp,
+ clang-analyzer-security.insecureAPI.mktemp,
+ clang-analyzer-security.insecureAPI.rand,
+ clang-analyzer-security.insecureAPI.strcpy,
+ clang-analyzer-security.insecureAPI.vfork,
+ clang-analyzer-unix.API,
+ clang-analyzer-unix.DynamicMemoryModeling,
+ clang-analyzer-unix.Errno,
+ clang-analyzer-unix.Malloc,
+ clang-analyzer-unix.MallocSizeof,
+ clang-analyzer-unix.MismatchedDeallocator,
+ clang-analyzer-unix.StdCLibraryFunctions,
+ clang-analyzer-unix.Vfork,
+ clang-analyzer-unix.cstring.BadSizeArg,
+ clang-analyzer-unix.cstring.CStringModeling,
+ clang-analyzer-unix.cstring.NullArg,
+ clang-analyzer-valist.CopyToSelf,
+ clang-analyzer-valist.Uninitialized,
+ clang-analyzer-valist.Unterminated,
+ clang-analyzer-valist.ValistBase,
+ clang-analyzer-webkit.NoUncountedMemberChecker,
+ clang-analyzer-webkit.RefCntblBaseVirtualDtor,
+ clang-analyzer-webkit.UncountedLambdaCapturesChecker,
+ cppcoreguidelines-avoid-capturing-lambda-coroutines,
+ cppcoreguidelines-avoid-goto,
+ cppcoreguidelines-avoid-reference-coroutine-parameters,
+ cppcoreguidelines-c-copy-assignment-signature,
+ cppcoreguidelines-interfaces-global-init,
+ cppcoreguidelines-misleading-capture-default-by-value,
+ cppcoreguidelines-narrowing-conversions,
+ cppcoreguidelines-no-malloc,
+ cppcoreguidelines-no-suspend-with-lock,
+ cppcoreguidelines-noexcept-destructor,
+ cppcoreguidelines-noexcept-move-operations,
+ cppcoreguidelines-noexcept-swap,
+ cppcoreguidelines-prefer-member-initializer,
+ cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+ cppcoreguidelines-pro-type-const-cast,
+ cppcoreguidelines-pro-type-static-cast-downcast,
+ cppcoreguidelines-pro-type-union-access,
+ cppcoreguidelines-rvalue-reference-param-not-moved,
+ cppcoreguidelines-slicing,
+ cppcoreguidelines-special-member-functions,
+ cppcoreguidelines-use-default-member-init,
+ cppcoreguidelines-virtual-class-destructor,
+ misc-coroutine-hostile-raii,
+ misc-header-include-cycle,
+ misc-misleading-bidirectional,
+ misc-misleading-identifier,
+ misc-misplaced-const,
+ misc-new-delete-overloads,
+ misc-non-copyable-objects,
+ misc-redundant-expression,
+ misc-static-assert,
+ misc-throw-by-value-catch-by-reference,
+ misc-unconventional-assign-operator,
+ misc-uniqueptr-reset-release,
+ misc-unused-alias-decls,
+ misc-unused-parameters,
+ misc-unused-using-decls,
+ modernize-deprecated-headers,
+ modernize-deprecated-ios-base-aliases,
+ modernize-loop-convert,
+ modernize-make-shared,
+ modernize-make-unique,
+ modernize-raw-string-literal,
+ modernize-redundant-void-arg,
+ modernize-replace-auto-ptr,
+ modernize-replace-random-shuffle,
+ modernize-return-braced-init-list,
+ modernize-shrink-to-fit,
+ modernize-unary-static-assert,
+ modernize-use-bool-literals,
+ modernize-use-default-member-init,
+ modernize-use-emplace,
+ modernize-use-equals-default,
+ modernize-use-equals-delete,
+ modernize-use-noexcept,
+ modernize-use-starts-ends-with,
+ modernize-use-std-numbers,
+ modernize-use-transparent-functors,
+ modernize-use-uncaught-exceptions,
+ performance-faster-string-find,
+ performance-for-range-copy,
+ performance-implicit-conversion-in-loop,
+ performance-inefficient-algorithm,
+ performance-inefficient-string-concatenation,
+ performance-inefficient-vector-operation,
+ performance-move-const-arg,
+ performance-move-constructor-init,
+ performance-no-automatic-move,
+ performance-no-int-to-ptr,
+ performance-noexcept-destructor,
+ performance-noexcept-move-constructor,
+ performance-noexcept-swap,
+ performance-trivially-destructible,
+ performance-type-promotion-in-math-fn,
+ performance-unnecessary-copy-initialization,
+ readability-avoid-const-params-in-decls,
+ readability-avoid-nested-conditional-operator,
+ readability-avoid-return-with-void-value,
+ readability-avoid-unconditional-preprocessor-if,
+ readability-braces-around-statements,
+ readability-const-return-type,
+ readability-container-contains,
+ readability-container-data-pointer,
+ readability-delete-null-pointer,
+ readability-deleted-default,
+ readability-duplicate-include,
+ readability-function-size,
+ readability-identifier-naming,
+ readability-implicit-bool-conversion,
+ readability-isolate-declaration,
+ readability-misleading-indentation,
+ readability-misplaced-array-index,
+ readability-non-const-parameter,
+ readability-operators-representation,
+ readability-redundant-access-specifiers,
+ readability-redundant-casting,
+ readability-redundant-declaration,
+ readability-redundant-function-ptr-dereference,
+ readability-redundant-member-init,
+ readability-redundant-preprocessor,
+ readability-redundant-smartptr-get,
+ readability-redundant-string-init,
+ readability-reference-to-constructed-temporary,
+ readability-simplify-subscript-expr,
+ readability-static-definition-in-anonymous-namespace,
+ readability-string-compare,
+ readability-uniqueptr-delete-release,
+ readability-uppercase-literal-suffix
+ '
CheckOptions:
- - { key: readability-identifier-naming.ClassCase, value: CamelCase }
- - { key: readability-identifier-naming.FunctionCase, value: camelBack }
- - { key: readability-identifier-naming.NamespaceCase, value: lower_case }
+- key: readability-identifier-naming.ClassCase
+ value: CamelCase
+- key: readability-identifier-naming.FunctionCase
+ value: camelBack
+- key: readability-identifier-naming.NamespaceCase
+ value: lower_case
+
+HeaderFilterRegex: (?!^subprojects).*
+
+WarningsAsErrors: '*'
diff --git a/host-transport-extensions/pldm/common/pldm_utils.cpp b/host-transport-extensions/pldm/common/pldm_utils.cpp
index a951fd7..40f7025 100644
--- a/host-transport-extensions/pldm/common/pldm_utils.cpp
+++ b/host-transport-extensions/pldm/common/pldm_utils.cpp
@@ -40,7 +40,7 @@
void PLDMInstanceManager::initPLDMInstanceIdDb()
{
auto rc = pldm_instance_db_init_default(&pldmInstanceIdDb);
- if (rc)
+ if (rc != 0)
{
lg2::error("Error calling pldm_instance_db_init_default, rc = {RC}",
"RC", rc);
@@ -53,7 +53,7 @@
void PLDMInstanceManager::destroyPLDMInstanceIdDb()
{
auto rc = pldm_instance_db_destroy(pldmInstanceIdDb);
- if (rc)
+ if (rc != 0)
{
lg2::error("pldm_instance_db_destroy failed rc = {RC}", "RC", rc);
}
@@ -70,7 +70,7 @@
rc = pldm_instance_id_alloc(pldmInstanceIdDb, tid, &instanceID);
}
- if (rc)
+ if (rc != 0)
{
lg2::error("Failed to get instance id, rc = {RC}", "RC", rc);
elog<NotAllowed>(Reason(
@@ -86,7 +86,7 @@
void freePLDMInstanceID(pldm_instance_id_t instanceID, uint8_t tid)
{
auto rc = pldm_instance_id_free(pldmInstanceIdDb, tid, instanceID);
- if (rc)
+ if (rc != 0)
{
lg2::error(
"pldm_instance_id_free failed to free id = {ID} of tid = {TID} rc = {RC}",
@@ -97,7 +97,7 @@
int openPLDM(mctp_eid_t eid)
{
auto fd = -1;
- if (pldmTransport)
+ if (pldmTransport != nullptr)
{
lg2::error("open: pldmTransport already setup!");
elog<NotAllowed>(Reason(
@@ -122,7 +122,7 @@
int openMctpDemuxTransport(mctp_eid_t eid)
{
int rc = pldm_transport_mctp_demux_init(&mctpDemux);
- if (rc)
+ if (rc != 0)
{
lg2::error(
"openMctpDemuxTransport: Failed to init MCTP demux transport. rc = {RC}",
@@ -131,7 +131,7 @@
}
rc = pldm_transport_mctp_demux_map_tid(mctpDemux, eid, eid);
- if (rc)
+ if (rc != 0)
{
lg2::error(
"openMctpDemuxTransport: Failed to setup tid to eid mapping. rc = {RC}",
@@ -143,7 +143,7 @@
struct pollfd pollfd;
rc = pldm_transport_mctp_demux_init_pollfd(pldmTransport, &pollfd);
- if (rc)
+ if (rc != 0)
{
lg2::error("openMctpDemuxTransport: Failed to get pollfd. rc = {RC}",
"RC", rc);