Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-debug-collector / 5fd768d699d331418c85cd3b9762eac34c602ac2
commit5fd768d699d331418c85cd3b9762eac34c602ac2[log] [tgz]
authorEd Tanous <edtanous@google.com>Mon Jan 09 09:26:11 2023 -0800
committerEd Tanous <edtanous@google.com>Mon Jan 09 09:29:56 2023 -0800
tree69564d84b6c64508bf06830710152ef27861f631
parent9d26e4fa3d9e5e736c631c81e2981da844825b87 [diff]
Remove double inheritance on faultlog entry

This log entry appears to have inherited from
sdbusplus::server::object_t twice, once directly, and once through its
inheritance of phosphor::dump::entry.  This is causing a warning on
destructor ordering.

Looking at the code, there is a defer signal, but it's not clear if
that's what the code was trying to accomplish.  Regardless, this gets
the code to compile again.

I'm open to input if there's a better way to fix this.

Change-Id: I9c7b3f18d049b7291ee799935002aa9fb129cbf9
Signed-off-by: Ed Tanous <edtanous@google.com>
1 file changed
tree: 69564d84b6c64508bf06830710152ef27861f631
  1. dump-extensions/
  2. host-transport-extensions/
  3. subprojects/
  4. test/
  5. tools/
  6. xyz/
  7. .clang-format
  8. .gitignore
  9. .shellcheck-ignore
  10. bmc_dump_entry.cpp
  11. bmc_dump_entry.hpp
  12. core_manager.cpp
  13. core_manager.hpp
  14. core_manager_main.cpp
  15. dump-extensions.hpp
  16. dump_entry.cpp
  17. dump_entry.hpp
  18. dump_internal.hpp
  19. dump_manager.cpp
  20. dump_manager.hpp
  21. dump_manager_bmc.cpp
  22. dump_manager_bmc.hpp
  23. dump_manager_faultlog.cpp
  24. dump_manager_faultlog.hpp
  25. dump_manager_main.cpp
  26. dump_offload.cpp
  27. dump_offload.hpp
  28. dump_serialize.cpp
  29. dump_serialize.hpp
  30. dump_utils.cpp
  31. dump_utils.hpp
  32. elog_watch.cpp
  33. elog_watch.hpp
  34. errors_map.mako.hpp
  35. errors_map_gen.py
  36. example_errors_watch.yaml
  37. faultlog_dump_entry.cpp
  38. faultlog_dump_entry.hpp
  39. ffdc
  40. host_transport_exts.hpp
  41. LICENSE
  42. meson.build
  43. meson_options.txt
  44. OWNERS
  45. ramoops_manager.cpp
  46. ramoops_manager.hpp
  47. ramoops_manager_main.cpp
  48. README.md
  49. watch.cpp
  50. watch.hpp
README.md

phosphor-debug-collector

Phosphor Debug Collector provides mechanisms to collect various log files and system parameters. Used to troubleshoot problems in OpenBMC based systems.

One such mechanism is dreport, a script that collects debug data and packages it into an archive file.

To Build

To build this package with meson, do the following steps:

    1. meson builddir
    2. ninja -C builddir

To clean the built files run ninja -C builddir clean.

To run unit tests

Tests can be run in the CI docker container, refer local-ci-build

or with an OpenBMC x86 sdk(see below for x86 steps).

meson -Dtests=enabled build
ninja -C build test