commit 73f64076834f4f565e4ded9e28f3e3dabc8fb108
author Patrick Williams <patrick@stwcx.xyz> Fri Apr 01 17:04:47 2022 -0500
committer Jayanth Othayoth <ojayanth@gmail.com> Fri Apr 08 14:01:18 2022 +0000
tree 04c9aa3bfe10f591c21d1b5b1e5572ea1fd0e537
parent 9e682c5139007f1b61421bf2473f064394276d5b

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications.  Map all `true` occurrences to
`action::defer_emit` or `action::emit_no_signals` as appropriate.

- DumpEntry: emit_no_signals (secondary object)
- {bmc,resource,system}::DumpEntry: defer_emit (primary object)
- Manager: defer_emit (primary object)

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I91990031384230550903a46332adc04d691a3cb9

bmc_dump_entry.hpp

diff --git a/bmc_dump_entry.hpp b/bmc_dump_entry.hpp
index 67209f3..24f0fcd 100644
--- a/bmc_dump_entry.hpp
+++ b/bmc_dump_entry.hpp
@@ -56,7 +56,7 @@
           const std::filesystem::path& file,
           phosphor::dump::OperationStatus status,
           phosphor::dump::Manager& parent) :
-        EntryIfaces(bus, objPath.c_str(), true),
+        EntryIfaces(bus, objPath.c_str(), EntryIfaces::action::defer_emit),
         phosphor::dump::Entry(bus, objPath.c_str(), dumpId, timeStamp, fileSize,
                               status, parent),
         file(file)

dump-extensions/openpower-dumps/resource_dump_entry.hpp

diff --git a/dump-extensions/openpower-dumps/resource_dump_entry.hpp b/dump-extensions/openpower-dumps/resource_dump_entry.hpp
index d1209ca..7fedfba 100644
--- a/dump-extensions/openpower-dumps/resource_dump_entry.hpp
+++ b/dump-extensions/openpower-dumps/resource_dump_entry.hpp
@@ -56,7 +56,7 @@
           std::string vspStr, std::string pwd,
           phosphor::dump::OperationStatus status,
           phosphor::dump::Manager& parent) :
-        EntryIfaces(bus, objPath.c_str(), true),
+        EntryIfaces(bus, objPath.c_str(), EntryIfaces::action::defer_emit),
         phosphor::dump::Entry(bus, objPath.c_str(), dumpId, timeStamp, dumpSize,
                               status, parent)
     {

dump-extensions/openpower-dumps/system_dump_entry.hpp

diff --git a/dump-extensions/openpower-dumps/system_dump_entry.hpp b/dump-extensions/openpower-dumps/system_dump_entry.hpp
index 7cf07c6..f09fafc 100644
--- a/dump-extensions/openpower-dumps/system_dump_entry.hpp
+++ b/dump-extensions/openpower-dumps/system_dump_entry.hpp
@@ -50,7 +50,7 @@
           uint64_t timeStamp, uint64_t dumpSize, const uint32_t sourceId,
           phosphor::dump::OperationStatus status,
           phosphor::dump::Manager& parent) :
-        EntryIfaces(bus, objPath.c_str(), true),
+        EntryIfaces(bus, objPath.c_str(), EntryIfaces::action::defer_emit),
         phosphor::dump::Entry(bus, objPath.c_str(), dumpId, timeStamp, dumpSize,
                               status, parent)
     {

dump_entry.hpp

diff --git a/dump_entry.hpp b/dump_entry.hpp
index cbeb012..7a8bba3 100644
--- a/dump_entry.hpp
+++ b/dump_entry.hpp
@@ -60,7 +60,7 @@
     Entry(sdbusplus::bus::bus& bus, const std::string& objPath, uint32_t dumpId,
           uint64_t timeStamp, uint64_t dumpSize, OperationStatus dumpStatus,
           Manager& parent) :
-        EntryIfaces(bus, objPath.c_str(), true),
+        EntryIfaces(bus, objPath.c_str(), EntryIfaces::action::emit_no_signals),
         parent(parent), id(dumpId)
     {
         size(dumpSize);

dump_manager.hpp

diff --git a/dump_manager.hpp b/dump_manager.hpp
index 3f111f3..1f5e3c7 100644
--- a/dump_manager.hpp
+++ b/dump_manager.hpp
@@ -41,7 +41,7 @@
      */
     Manager(sdbusplus::bus::bus& bus, const char* path,
             const std::string& baseEntryPath) :
-        Iface(bus, path, true),
+        Iface(bus, path, Iface::action::defer_emit),
         bus(bus), lastEntryId(0), baseEntryPath(baseEntryPath)
     {}