commit 8e62d555698aaed7071e1a01ebc318271a19fc36
author Patrick Williams <patrick@stwcx.xyz> Wed Feb 05 17:30:23 2025 -0500
committer Jayanth Othayoth <ojayanth@gmail.com> Wed Feb 05 22:33:56 2025 -0600
tree 0ebcd699247322df67d5c0e12ac08cdf4531d825
parent e9ec952ef5f4788c74332b03f0d8d4f041910a47

host-transport: pldm: fix variable shadow

Inside a single function are two variables both named 'eid' but
of different types.  This causes confusion to clang and implicit
constructors are inadvertently called.  Eliminate the variable shadow.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2c15799718b0129aad01ab857dec7a255cbf36a3

host-transport-extensions/pldm/oem/ibm/pldm_oem_cmds.cpp

diff --git a/host-transport-extensions/pldm/oem/ibm/pldm_oem_cmds.cpp b/host-transport-extensions/pldm/oem/ibm/pldm_oem_cmds.cpp
index b51aeaf..0836c44 100644
--- a/host-transport-extensions/pldm/oem/ibm/pldm_oem_cmds.cpp
+++ b/host-transport-extensions/pldm/oem/ibm/pldm_oem_cmds.cpp
@@ -79,11 +79,11 @@
     }
     else
     {
-        std::string eid;
-        eidFile >> eid;
-        if (!eid.empty())
+        std::string eidStr;
+        eidFile >> eidStr;
+        if (!eidStr.empty())
         {
-            eid = strtol(eid.c_str(), nullptr, 10);
+            eid = strtol(eidStr.c_str(), nullptr, 10);
         }
         else
         {