| commit | 90d147a1ee5340278506bbdf94edc32bb77154f2 | [log] [tgz] |
|---|---|---|
| author | William A. Kennington III <wak@google.com> | Tue Jun 12 16:42:33 2018 -0700 |
| committer | William A. Kennington III <wak@google.com> | Tue Jun 12 16:53:21 2018 -0700 |
| tree | bd60788e13dea94b348236f156be3bc51c1d9e30 | |
| parent | 15cd3ce7045fb4da18c0b9dc89772d9807490a54 [diff] |
elog_watch: Fix parsing of elog add requests
Requests come in the form "oa{sa{sv}}". However, the way sdbusplus was
interpreting the type of our message "a{oa{sa{sv}}}" since tuples are
not allowed to consume multiple arguments during the read call as that
would be ambiguous. This fixes the type issues.
Prior to the change to sdbusplus that introduces error handling for the
read calls, the sd_bus_message_{enter,exit}_container were failing
during the read on the pair. Luckily this produces the expected result
for the read and our old code was "working".
This also cleans up an unnecessary string move.
Tested:
Builds and no longer produces errors on zaius when elogs are added.
Change-Id: Ifc5394f3f361e8932c939376bd0bf5b4e3ca589c
Signed-off-by: William A. Kennington III <wak@google.com>
Phosphor Debug Collector provides mechanisms to collect various log files and system parameters. Used to troubleshoot problems in OpenBMC based systems.
To build this package, do the following steps:
1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make
To clean the repository run `./bootstrap.sh clean`.