Move generated error map to cpp file
This commit changes the generation location of error map
from a header file (.hpp) to a source file (.cpp).
This change enhances code organization, separates
declaration from implementation.
In an upcoming change, retaining the map in the header
file results in a duplicate definition error.
Therefore, to avoid these errors and ensure smooth future
updates, the error map needs to be generated in the
.cpp file.
Tests:
Created error log dumps by commiting InternalFailure
Change-Id: I01e4503e24ebf9045793014060107cca4ff440ad
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
diff --git a/meson.build b/meson.build
index e25247a..1ba3e32 100644
--- a/meson.build
+++ b/meson.build
@@ -122,26 +122,25 @@
configure_file(configuration : conf_data,
output : 'config.h'
)
-
subdir('xyz/openbmc_project/Dump/Internal/Create')
python = find_program('python3')
errors_map_gen_file_loc = meson.project_source_root()
errors_map_gen_file_loc += '/errors_map_gen.py'
-errors_map_hpp = custom_target(
- 'errors_map.hpp',
+errors_map_cpp = custom_target(
+ 'errors_map.cpp',
command : [
python,
errors_map_gen_file_loc,
'-i',
get_option('ERROR_MAP_YAML')
],
- depend_files : [ 'errors_map.mako.hpp',
+ depend_files : [ 'errors_map.mako.cpp',
'errors_map_gen.py',
get_option('ERROR_MAP_YAML')
],
- output : 'errors_map.hpp'
+ output : 'errors_map.cpp'
)
phosphor_dump_manager_sources = [
@@ -151,7 +150,7 @@
'dump_manager_main.cpp',
'dump_serialize.cpp',
'elog_watch.cpp',
- errors_map_hpp,
+ errors_map_cpp,
common_hpp,
server_hpp,
server_cpp,