Remove internal dump create interface
The createDump method was revised to support key-value
parameters, allowing flexible dump type specification.
This change negates the need for the internal create
interface, exclusive to the phosphor-debug-collector
repository.
This commit removes all instances of the internal create
method, replacing them with the updated createDump method.
The modified createDump approach ensures a consistent dump
initiation procedure and enables all applications to
request various dump types.
Tests:
- Validate the creation of a user-requested BMC dump.
- Validate the creation of a dump due to an InternalFailure.
- Generate a core dump to validate the corresponding BMC dump creation.
- Ensure that system-generated dumps are allowed when user-requested
dump is in progress.
- Ensure simultaneous user requested dumps are prevented
Change-Id: I9f91375788201e2badf51d87f8117154a8e1ed8a
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
diff --git a/elog_watch.cpp b/elog_watch.cpp
index d43ca48..b3ba0b6 100644
--- a/elog_watch.cpp
+++ b/elog_watch.cpp
@@ -2,7 +2,6 @@
#include "elog_watch.hpp"
-#include "dump_internal.hpp"
#include "dump_serialize.hpp"
#include "errors_map.hpp"
#include "xyz/openbmc_project/Dump/Create/error.hpp"
@@ -11,6 +10,7 @@
#include <phosphor-logging/elog.hpp>
#include <phosphor-logging/lg2.hpp>
#include <sdbusplus/exception.hpp>
+#include <xyz/openbmc_project/Dump/Create/common.hpp>
#include <fstream>