Remove internal dump create interface
The createDump method was revised to support key-value
parameters, allowing flexible dump type specification.
This change negates the need for the internal create
interface, exclusive to the phosphor-debug-collector
repository.
This commit removes all instances of the internal create
method, replacing them with the updated createDump method.
The modified createDump approach ensures a consistent dump
initiation procedure and enables all applications to
request various dump types.
Tests:
- Validate the creation of a user-requested BMC dump.
- Validate the creation of a dump due to an InternalFailure.
- Generate a core dump to validate the corresponding BMC dump creation.
- Ensure that system-generated dumps are allowed when user-requested
dump is in progress.
- Ensure simultaneous user requested dumps are prevented
Change-Id: I9f91375788201e2badf51d87f8117154a8e1ed8a
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
diff --git a/elog_watch.hpp b/elog_watch.hpp
index 9fa270a..d8e6a8f 100644
--- a/elog_watch.hpp
+++ b/elog_watch.hpp
@@ -40,7 +40,7 @@
/** @brief constructs watch for elog add and delete signals.
* @param[in] bus - The Dbus bus object
- * @param[in] intMgr - Dump internal Manager object
+ * @param[in] mgr - Dump internal Manager object
*/
Watch(sdbusplus::bus_t& bus, Mgr& mgr);