Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-debug-collector / 0eadeb7e78ea549da1c40016c9dc43f52df8b70d
commit0eadeb7e78ea549da1c40016c9dc43f52df8b70d[log] [tgz]
authorLei YU <yulei.sh@bytedance.com>Fri Jul 23 15:47:42 2021 +0800
committerJayanth Othayoth <ojayanth@gmail.com>Tue Aug 03 10:56:11 2021 +0000
treef326aee16ef629632a245d5986450c8208c34caa
parent796a92ee40170fb8936a9509d279fd650f6bbe02 [diff]
core_manager: Handle dbus exceptions

The code was using deprecated is_method_error() to check errors, but the
sdbusplus now throws on DBus errors.
When there is no space for new dump (by default 1M), it will get an
exception and crashes like below:

    phosphor-dump-monitor[166]: terminate called after throwing an instance of 'sdbusplus::exception::SdBusError'
    phosphor-dump-monitor[166]:   what():  sd_bus_call noreply: xyz.openbmc_project.Dump.Create.Error.QuotaExceeded: Dump not captured due to a cap.

Add try-catch to handle the exceptions.

Tested: Verify when there is no space for new dump there is no more
        dump-monitor crash and it just prints an error:

    phosphor-dump-monitor[174]: Failed to create dump

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Ibd290587fd16c59be98ccff52887f598ee5b5c33
1 file changed
tree: f326aee16ef629632a245d5986450c8208c34caa
  1. dump-extensions/
  2. host-transport-extensions/
  3. subprojects/
  4. test/
  5. tools/
  6. xyz/
  7. .clang-format
  8. .gitignore
  9. bmc_dump_entry.cpp
  10. bmc_dump_entry.hpp
  11. core_manager.cpp
  12. core_manager.hpp
  13. core_manager_main.cpp
  14. dump-extensions.hpp
  15. dump_entry.cpp
  16. dump_entry.hpp
  17. dump_internal.hpp
  18. dump_manager.cpp
  19. dump_manager.hpp
  20. dump_manager_bmc.cpp
  21. dump_manager_bmc.hpp
  22. dump_manager_main.cpp
  23. dump_offload.cpp
  24. dump_offload.hpp
  25. dump_serialize.cpp
  26. dump_serialize.hpp
  27. dump_utils.cpp
  28. dump_utils.hpp
  29. elog_watch.cpp
  30. elog_watch.hpp
  31. errors_map.mako.hpp
  32. errors_map_gen.py
  33. example_errors_watch.yaml
  34. ffdc
  35. host_transport_exts.hpp
  36. LICENSE
  37. MAINTAINERS
  38. meson.build
  39. meson_options.txt
  40. ramoops_manager.cpp
  41. ramoops_manager.hpp
  42. ramoops_manager_main.cpp
  43. README.md
  44. watch.cpp
  45. watch.hpp
README.md

phosphor-debug-collector

Phosphor Debug Collector provides mechanisms to collect various log files and system parameters. Used to troubleshoot problems in OpenBMC based systems.

To Build

To build this package with meson, do the following steps:

    1. meson builddir
    2. ninja -C builddir

To clean the built files run ninja -C builddir clean.

To run unit tests

Tests can be run in the CI docker container, refer local-ci-build

or with an OpenBMC x86 sdk(see below for x86 steps).

meson -Dtests=enabled build
ninja -C build test