commit fdc0c3a12d58a0694718fe4616d9d91eab97b460
author Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> Mon Sep 14 01:38:27 2020 -0500
committer Jayanth Othayoth <ojayanth@in.ibm.com> Fri Sep 25 13:49:19 2020 +0000
tree fd49d6eaa48c2fa6c427690847f0e5ac79ba65a1
parent 50427253669148dfc3eb1c49c80effbddf4a0044

Fix shellcheck errors in dreport

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I64e9de12b9e8c71fc501936a39926388729fb370

tools/dreport.d/dreport

diff --git a/tools/dreport.d/dreport b/tools/dreport.d/dreport
index a6c1e68..165e11e 100755
--- a/tools/dreport.d/dreport
+++ b/tools/dreport.d/dreport
@@ -194,10 +194,10 @@
     summary_log="$name_dir/$SUMMARY_LOG"
 
     #Type
-    if [[ !($dump_type = $TYPE_USER || \
-            $dump_type = $TYPE_CORE || \
-            $dump_type = $TYPE_ELOG || \
-            $dump_type = $TYPE_CHECKSTOP) ]]; then
+    if [[ ! ($dump_type = $TYPE_USER || \
+             $dump_type = $TYPE_CORE || \
+             $dump_type = $TYPE_ELOG || \
+             $dump_type = $TYPE_CHECKSTOP) ]]; then
        log_error "Invalid -type, Only summary log is available"
        dump_type=$SUMMARY_DUMP
     fi

tools/dreport.d/include.d/functions

diff --git a/tools/dreport.d/include.d/functions b/tools/dreport.d/include.d/functions
index 3cd57c3..8c4345d 100755
--- a/tools/dreport.d/include.d/functions
+++ b/tools/dreport.d/include.d/functions
@@ -118,9 +118,9 @@
 # @param error message
 function log_error()
 {
-   echo $($TIME_STAMP) "ERROR: $@" >> $dreport_log
+   echo $($TIME_STAMP) "ERROR: $*" >> $dreport_log
    if ((quiet != TRUE)); then
-      echo $($TIME_STAMP) "ERROR: $@" >&2
+      echo $($TIME_STAMP) "ERROR: $*" >&2
    fi
 }
 
@@ -129,9 +129,9 @@
 function log_warning()
 {
     if ((verbose == TRUE)); then
-        echo $($TIME_STAMP) "WARNING: $@" >> $dreport_log
+        echo $($TIME_STAMP) "WARNING: $*" >> $dreport_log
         if ((quiet != TRUE)); then
-            echo $($TIME_STAMP) "WARNING: $@" >&2
+            echo $($TIME_STAMP) "WARNING: $*" >&2
         fi
     fi
 }
@@ -141,9 +141,9 @@
 function log_info()
 {
     if ((verbose == TRUE)); then
-        echo $($TIME_STAMP) "INFO: $@" >> $dreport_log
+        echo $($TIME_STAMP) "INFO: $*" >> $dreport_log
         if ((quiet != TRUE)); then
-            echo $($TIME_STAMP) "INFO: $@" >&1
+            echo $($TIME_STAMP) "INFO: $*" >&1
         fi
     fi
 }
@@ -152,8 +152,8 @@
 # @param message
 function log_summary()
 {
-    echo $($TIME_STAMP) "$@" >> $summary_log
+    echo $($TIME_STAMP) "$*" >> $summary_log
     if ((quiet != TRUE)); then
-        echo $($TIME_STAMP) "$@" >&1
+        echo $($TIME_STAMP) "$*" >&1
     fi
 }