commit 9b06243df8af58ba5e8b51353508e01de9b51831
author Matt Spinler <spinler@us.ibm.com> Thu Jan 26 14:38:50 2023 -0600
committer Matt Spinler <spinler@us.ibm.com> Tue Jan 31 19:29:10 2023 +0000
tree 2a6388b5bbc4ead4b9c876f851cdc8044993de68
parent fce1490811f595d9f95442fb0fc0de19ac1120ca

Add explicit keyword to 1 arg constructors

The cppcheck tool complains about it otherwise.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id977a6c349b0b49354b52ac994ea7742e0a39307

control/json/utils/modifier.cpp

diff --git a/control/json/utils/modifier.cpp b/control/json/utils/modifier.cpp
index 501a035..91978e7 100644
--- a/control/json/utils/modifier.cpp
+++ b/control/json/utils/modifier.cpp
@@ -93,7 +93,7 @@
  */
 struct MinusOperator : public Modifier::BaseOperator
 {
-    MinusOperator(const json& jsonObj) :
+    explicit MinusOperator(const json& jsonObj) :
         arg(ConfigBase::getJsonValue(jsonObj["value"]))
     {}
 
@@ -162,7 +162,7 @@
  */
 struct LessThanOperator : public Modifier::BaseOperator
 {
-    LessThanOperator(const json& jsonObj)
+    explicit LessThanOperator(const json& jsonObj)
     {
         const auto& valueArray = jsonObj["value"];
         if (!valueArray.is_array())

control/json/utils/modifier.hpp

diff --git a/control/json/utils/modifier.hpp b/control/json/utils/modifier.hpp
index 8959203..92fdb70 100644
--- a/control/json/utils/modifier.hpp
+++ b/control/json/utils/modifier.hpp
@@ -80,7 +80,7 @@
      *
      * @param[in] jsonObj - The JSON config object
      */
-    Modifier(const json& jsonObj);
+    explicit Modifier(const json& jsonObj);
 
     /**
      * @brief Performs the operation

control/json/utils/pcie_card_metadata.hpp

diff --git a/control/json/utils/pcie_card_metadata.hpp b/control/json/utils/pcie_card_metadata.hpp
index a879a51..c6b2083 100644
--- a/control/json/utils/pcie_card_metadata.hpp
+++ b/control/json/utils/pcie_card_metadata.hpp
@@ -68,7 +68,7 @@
      *
      * @param[in] systemNames - The system names values
      */
-    PCIeCardMetadata(const std::vector<std::string>& systemNames);
+    explicit PCIeCardMetadata(const std::vector<std::string>& systemNames);
 
     /**
      * @brief Look up a floor index based on a card's metadata