monitor: Trust group cancel/start monitoring
Any fan monitoring trust groups configured should cancel the monitoring
of all fan sensors configured in the trust group for all monitoring
methods(timer based or count based) when the group is determined not to
be trusted.
Also, the trust manager should restart monitoring all the sensors in the
group by processing each sensor against the configured monitoring
method. This matches how each sensor is processed on each tach changed
signal where only when a tach changed signal is received does the trust
state of the sensor get checked prior to processing the state of the
sensor.
Tested:
Verify fan sensors in trust group's functional state is correct
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Change-Id: I7b2ffc538eb1f17017826235353dba85e4f92ebe
diff --git a/monitor/trust_manager.hpp b/monitor/trust_manager.hpp
index 1925003..871d9be 100644
--- a/monitor/trust_manager.hpp
+++ b/monitor/trust_manager.hpp
@@ -69,10 +69,9 @@
*
* While checking group trust, the code will also check
* if the trust status has just changed. If the status
- * just changed to false, it will stop the tach error
- * timers for that group so these untrusted sensors won't
- * cause errors. If changed to true, it will start those timers
- * back up again.
+ * just changed to false, it will cancel the tach error
+ * method for that group so these untrusted sensors won't
+ * cause errors.
*
* Note this means groups should be designed such that
* in the same call to this function a sensor shouldn't
@@ -99,14 +98,14 @@
if (changed)
{
- group->stopTimers();
+ group->cancelMonitoring();
}
}
else
{
if (changed)
{
- group->startTimers();
+ group->startMonitoring();
}
}
}