Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 5ea83fad72af5389c215c5da45c6342c63e9557f
commit5ea83fad72af5389c215c5da45c6342c63e9557f[log] [tgz]
authorThang Tran <thuutran@amperecomputing.com>Mon Oct 16 14:37:56 2023 +0700
committerThang Tran <thuutran@amperecomputing.com>Mon Oct 16 15:15:36 2023 +0700
tree6152c4629e934826912ceb41a67c5c69767c180b
parent4fc7b69ec4cabe9e9fd20ea6f038e37493118de5 [diff]
dcmi: fix Get Sensor Info command

Issue: if users request to Get Sensors Info via "ipmitool dcmi sensors"
command, the Record ID of sensors always are 0x0000.

Root Cause: In the loop of scanning the configuration file to get the
record ID, it is using the "config" variable instead of the "reading"
variable. It makes the record ID always is 0x0000.

Solution: Replace the "config" variable with the "reading" variable.

Tested:
    1. Request to Get Sensors Info.
       $ipmitool dcmi sensors
    2. The list of sensors and temperature are shown.

Change-Id: If2b03b6b8a077a4e9239403ec9ecd640f645cbc0
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>
1 file changed
tree: 6152c4629e934826912ceb41a67c5c69767c180b
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. scripts/
  7. softoff/
  8. subprojects/
  9. test/
  10. user_channel/
  11. xyz/
  12. .build.sh
  13. .clang-format
  14. .gitignore
  15. .shellcheck
  16. .travis.yml
  17. apphandler.cpp
  18. apphandler.hpp
  19. chassishandler.cpp
  20. chassishandler.hpp
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. error-HostEvent.hpp
  24. fruread.hpp
  25. generate_whitelist.sh
  26. generate_whitelist_create.sh
  27. globalhandler.cpp
  28. globalhandler.hpp
  29. groupext.cpp
  30. host-cmd-manager.cpp
  31. host-cmd-manager.hpp
  32. host-interface.cpp
  33. host-interface.hpp
  34. host-ipmid-whitelist.conf
  35. ipmi_fru_info_area.cpp
  36. ipmi_fru_info_area.hpp
  37. ipmid-new.cpp
  38. ipmisensor.cpp
  39. ipmiwhitelist.hpp
  40. LICENSE
  41. meson.build
  42. meson.options
  43. OWNERS
  44. read_fru_data.cpp
  45. read_fru_data.hpp
  46. README.md
  47. selutility.cpp
  48. selutility.hpp
  49. sensordatahandler.cpp
  50. sensordatahandler.hpp
  51. sensorhandler.cpp
  52. sensorhandler.hpp
  53. settings.cpp
  54. settings.hpp
  55. storageaddsel.cpp
  56. storageaddsel.hpp
  57. storagehandler.cpp
  58. storagehandler.hpp
  59. sys_info_param.cpp
  60. sys_info_param.hpp
  61. systemintfcmds.cpp
  62. systemintfcmds.hpp
  63. testaddsel.cpp
  64. testit.cpp
  65. transporthandler.cpp
  66. transporthandler.hpp
  67. whitelist-filter.cpp
README.md

Compile ipmid with default options:

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults:

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report:

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage