commit 0634e9890854c294d5437ffaa06337fcdef5c5f9
author Arun P. Mohanan <arun.p.m@linux.intel.com> Mon Aug 30 15:21:33 2021 +0530
committer Vernon Mauery <vernon.mauery@linux.intel.com> Fri Sep 03 15:53:13 2021 +0000
tree ec6ce3905438ae750df8ad34d4fb3ef95815ef20
parent ef1259becab17e03cf31bc74e9db34ac98dd4298

Add check for reserved sensor number

Sensor number FFh is reserved. Add check for the same in 'Set Sensor
Reading And Event Status' command.

Tested: Verified command is returning 0xCC when sensor number is 0xFFh

Change-Id: Ib389552d6a56e36c89cf5d8ec81356a6ab3fc7fe
Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com>

sensorhandler.cpp

diff --git a/sensorhandler.cpp b/sensorhandler.cpp
index 4b6eb6e..ed02c62 100644
--- a/sensorhandler.cpp
+++ b/sensorhandler.cpp
@@ -350,6 +350,10 @@
     log<level::DEBUG>("IPMI SET_SENSOR",
                       entry("SENSOR_NUM=0x%02x", sensorNumber));
 
+    if (sensorNumber == 0xFF)
+    {
+        return ipmi::responseInvalidFieldRequest();
+    }
     ipmi::sensor::SetSensorReadingReq cmdData;
 
     cmdData.number = sensorNumber;