Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 0ab847959fb6fab8435e0319cc2d6ed150127ef3
commit0ab847959fb6fab8435e0319cc2d6ed150127ef3[log] [tgz]
authorKonstantin Aladyshev <aladyshev22@gmail.com>Mon May 05 17:02:43 2025 +0300
committerKonstantin Aladyshev <aladyshev22@gmail.com>Fri Sep 05 16:31:14 2025 +0000
tree2cc9e46a44283a4e51e9ee15a65dfe6d19840d23
parent62be74f18e597534a6aecab3b6229082b5ffac21 [diff]
Handle Value::Unit::Percent unit correctly

Currently if a sensor unit is 'Value::Unit::Percent' the following
error message is generated:
"""
Unknown value unit type: = xyz.openbmc_project.Sensor.Value.Unit.Percent
"""
According to the IPMI specification if the sensor unit is percent the
'Percentage' bit should be set in the 'Sensor Units 1' field of the full
sensor record. Use 'set_percentage' function to set this field.
Also for consistency move the rest of the 'Sensor Units 1' field setting
inside the 'setUnitFieldsForObject' function.

Tested:
- Before
Each sensor with the 'Value::Unit::Percent' unit produces the 'Unknown
value unit type' error message
- After
No more 'Unknown value unit type' error messages from the percent unit
sensors.

Change-Id: I23048f91be0ca7ce749732c766d9f195e929c7b7
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
1 file changed
tree: 2cc9e46a44283a4e51e9ee15a65dfe6d19840d23
  1. app/
  2. dbus-sdr/
  3. docs/
  4. include/
  5. libipmid/
  6. oem/
  7. scripts/
  8. softoff/
  9. subprojects/
  10. test/
  11. transport/
  12. user_channel/
  13. xyz/
  14. .build.sh
  15. .clang-format
  16. .clang-tidy
  17. .gitignore
  18. .shellcheck
  19. .travis.yml
  20. apphandler.cpp
  21. apphandler.hpp
  22. chassishandler.cpp
  23. chassishandler.hpp
  24. dcmihandler.cpp
  25. dcmihandler.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. generate_whitelist_create.sh
  30. globalhandler.cpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmiallowlist.hpp
  40. ipmid-new.cpp
  41. ipmisensor.cpp
  42. LICENSE
  43. meson.build
  44. meson.options
  45. OWNERS
  46. read_fru_data.cpp
  47. read_fru_data.hpp
  48. README.md
  49. sbmrhandler.cpp
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. sys_info_param.cpp
  62. sys_info_param.hpp
  63. systemintfcmds.cpp
  64. systemintfcmds.hpp
  65. transportconstants.hpp
  66. transporthandler.cpp
  67. transporthandler.hpp
  68. whitelist-filter.cpp
README.md

phosphor-host-ipmid

Compile ipmid with default options

meson builddir
ninja -C builddir

Compile ipmid with yocto defaults

meson builddir -Dbuildtype=minsize -Db_lto=true -Dtests=disabled
ninja -C builddir

If any of the dependencies are not found on the host system during configuration, meson automatically gets them via its wrap dependencies mentioned in ipmid/subprojects.

Enable/Disable meson wrap feature

meson builddir -Dwrap_mode=nofallback
ninja -C builddir

Enable debug traces

meson builddir -Dbuildtype=debug
ninja -C builddir

Generate test coverage report

meson builddir -Db_coverage=true -Dtests=enabled
ninja -C builddir test
ninja -C builddir coverage