Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 0e2dbee2d19ee6865d6e95b07398943b8f536336
commit0e2dbee2d19ee6865d6e95b07398943b8f536336[log] [tgz]
authorjayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Thu Dec 26 13:03:04 2019 +0000
committerjayaprakash Mutyala <mutyalax.jayaprakash@intel.com>Thu Apr 02 10:02:46 2020 +0000
tree78cca7e26db0eab8833d17e64dc71495d8feb8e4
parentb741b990923a290d321f4bc3c7b8f897a826f854 [diff]
Fix for Callback privilege

Issue: Not returning proper error when user privilege is Callback

Returning proper error codes.

Tested:
Command:  ipmitool raw 0x06 0x40 0x3 0x42 0x41   //SetChannelAccess
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x40 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x40 0x3 0x42 0xc2 //SetChannelAccess
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x40 rsp=0x83): Unknown (0x83)
Command:  ipmitool user priv 2 0x01 1
Response: IPMI command failed: Invalid data field in request
          Set Privilege Level command failed (user 2)
Command:  ipmitool raw 0x06 0x38 1 1  //Get Channel Auth Capabilities
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x38 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x40 0x1 0x42 0x81  //SetChannelAccess
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x40 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x43 0x1 2 1 0  //Set User Access Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x43 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x43 0x2 1 2 0 //Set User Access Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x43 rsp=0xff): Unspecified error
Command:  ipmitool raw 0x06 0x42 0x02  //Get Channel Info Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x42 rsp=0x82): Unknown (0x82)
Command:  ipmitool raw 0x06 0x4E 0x02  //Get Channel Payload Support
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x4e rsp=0xff): Unspecified error
Command:  ipmitool raw 0x06 0x4E 0x0F  //Get Channel Payload Support
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x4e rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x4F 0x02 0x00 //Get Channel Payload Version
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x4f rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x4C 0x02 0x01 0x02 0x00 0x00 0x00
                                    //Set User Payload Access
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x4c rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x44 0x02 0x02  //Get User Access Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x44 rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x44 0x01 0x11  //Get User Access Command
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x44 rsp=0xc9): Parameter out of range
Command:  ipmitool raw 0x06 0x4D 0x02 0x02  //Get User Payload Access
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x4d rsp=0xcc): Invalid data field in request
Command:  ipmitool raw 0x06 0x40 0x3 0x44 0x43
                      // set channel access for Non-volatile priv limit
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x40 rsp=0x83): Unknown (0x83)
Command:  ipmitool raw 0x06 0x40 0x1 0x85 0x82
                      // set channel access for volatile priv limit
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
          cmd=0x40 rsp=0x83): Unknown (0x83)

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I4ff6fb5ae9a604e6b38fb92c249416605ec27cb5
6 files changed
tree: 78cca7e26db0eab8833d17e64dc71495d8feb8e4
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. globalhandler.cpp
  30. globalhandler.hpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmid-new.cpp
  40. ipmisensor.cpp
  41. ipmiwhitelist.hpp
  42. LICENSE
  43. MAINTAINERS
  44. Makefile.am
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. sample.cpp
  49. sample.h
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.