commit 0e862fabcc4772ec8f98c60ed3ddd004f785b6ce
author Chen,Yugang <yugang.chen@linux.intel.com> Fri Sep 06 11:03:05 2019 +0800
committer Vernon Mauery <vernon.mauery@linux.intel.com> Mon Sep 23 17:50:41 2019 +0000
tree bd229ed2d500fe50f75492030158934c8907d9aa
parent 98b43babb75177101499de4e8f55bbb19bea40ad

Static code analysis scan issue fix

Fix the issues found during code static scan

Tested:
test in board, function works fine.
1. busctl set-property for watchdog, it works fine.
2. It works by running "ipmitool chassis power soft".
3. run "ipmitool raw 0x6 0x46 1", get expected user information.

Change-Id: I7a2cc3c934db6a7531f8a8ea05956cb6d6337633
Signed-off-by: Chen,Yugang <yugang.chen@linux.intel.com>

app/watchdog_service.cpp

diff --git a/app/watchdog_service.cpp b/app/watchdog_service.cpp
index c567ca9..0eedf1b 100644
--- a/app/watchdog_service.cpp
+++ b/app/watchdog_service.cpp
@@ -153,7 +153,8 @@
         if (wasValid)
         {
             // Retry the request once in case the cached service was stale
-            return setProperty(key, val);
+            setProperty(key, val);
+            return;
         }
         log<level::ERR>("WatchdogService: Method error setting property",
                         entry("PROPERTY=%s", key.c_str()));

host-interface.cpp

diff --git a/host-interface.cpp b/host-interface.cpp
index 69ab376..1f9bfcb 100644
--- a/host-interface.cpp
+++ b/host-interface.cpp
@@ -54,7 +54,7 @@
                                          std::placeholders::_1,
                                          std::placeholders::_2));
 
-    return ipmid_send_cmd_to_host(std::move(cmd));
+    ipmid_send_cmd_to_host(std::move(cmd));
 }
 
 // Called into by Command Manager

user_channel/user_mgmt.cpp

diff --git a/user_channel/user_mgmt.cpp b/user_channel/user_mgmt.cpp
index bf43f88..d0dcb38 100644
--- a/user_channel/user_mgmt.cpp
+++ b/user_channel/user_mgmt.cpp
@@ -1635,7 +1635,7 @@
             auto usrObj = managedObjs.find(usersPath);
             if (usrObj != managedObjs.end())
             {
-                bool usrEnabled;
+                bool usrEnabled = false;
 
                 // User exist. Lets check and update other fileds
                 getUserObjProperties(usrObj->second, usrGrps, usrPriv,
@@ -1692,7 +1692,7 @@
     {
         std::vector<std::string> usrGrps;
         std::string usrPriv, userName;
-        bool usrEnabled;
+        bool usrEnabled = false;
         std::string usrObjPath = std::string(usrObj.first);
         if (getUserNameFromPath(usrObj.first.str, userName) != 0)
         {