commit 0e862fabcc4772ec8f98c60ed3ddd004f785b6ce
author Chen,Yugang <yugang.chen@linux.intel.com> Fri Sep 06 11:03:05 2019 +0800
committer Vernon Mauery <vernon.mauery@linux.intel.com> Mon Sep 23 17:50:41 2019 +0000
tree bd229ed2d500fe50f75492030158934c8907d9aa
parent 98b43babb75177101499de4e8f55bbb19bea40ad

Static code analysis scan issue fix

Fix the issues found during code static scan

Tested:
test in board, function works fine.
1. busctl set-property for watchdog, it works fine.
2. It works by running "ipmitool chassis power soft".
3. run "ipmitool raw 0x6 0x46 1", get expected user information.

Change-Id: I7a2cc3c934db6a7531f8a8ea05956cb6d6337633
Signed-off-by: Chen,Yugang <yugang.chen@linux.intel.com>

app/watchdog_service.cpp

diff --git a/app/watchdog_service.cpp b/app/watchdog_service.cpp
index c567ca9..0eedf1b 100644
--- a/app/watchdog_service.cpp
+++ b/app/watchdog_service.cpp
@@ -153,7 +153,8 @@
         if (wasValid)
         {
             // Retry the request once in case the cached service was stale
-            return setProperty(key, val);
+            setProperty(key, val);
+            return;
         }
         log<level::ERR>("WatchdogService: Method error setting property",
                         entry("PROPERTY=%s", key.c_str()));