tree 01226b30bcb53b97b95268e6794122dd660017fb
parent 3dad826bd7f8c03cf7f742c7051c9fc537ca0c6d
author krishnar4 <krishnar@ami.com> 1699259315 +0530
committer krishna Raj <krishnar@ami.com> 1701141037 +0000

apphandler: fix Set System Info command

Return proper error response for reserved data bytes

as per the ipmi specification,Set System Info parameters
takes block of string data and the first byte indicates the
encoding of the string. the bits[7:4] are reserved.

string data byte 1:
[7:4] - reserved
[3:0] - encoding
0h = ASCII+Latin1
1h = UTF-8
2h = UNICODE
all other = reserved.

This patch verifies if the reserveds bits
are being used and return proper error response

tested
//Before Fix:
1)Paramter 1
 ipmitool raw 0x06 0x58 0x01 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35

2)Parameter 2
ipmitool raw 0x06 0x58 0x02 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35

3)Parameter 3:
ipmitool raw 0x06 0x58 0x01 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35

//After Fix:
1)Parameter 1
ipmitool  raw 0x06 0x58 0x01 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34  0x35
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x58 rsp=0xcc): Invalid data field in request

2)Parameter 2
ipmitool raw 0x06 0x58 0x02 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x58 rsp=0xcc): Invalid data field in request

3)Parameter 3:
ipmitool raw 0x06 0x58 0x01 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35
Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x58 rsp=0xcc): Invalid data field in request

Change-Id: I8ac2c582bfc9029dc01008bbd665603562a9f275
Signed-off-by: krishnar4 <krishnar@ami.com>