cleanup: Remove all warning errors for the Meson build support
Remove all the build warning to prepare for the meson build.
Meson build will be in
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-host-ipmid/+/47748
Tested:
Ipmi command works fine the cleanup.
```
$ systemctl status phosphor-ipmi-host
● phosphor-ipmi-host.service - Phosphor Inband IPMI
Loaded: loaded (/lib/systemd/system/phosphor-ipmi-host.service; enabled; vendor preset: enabled)
Active: active (running) since Thu 1970-01-08 21:20:56 UTC; 21s ago
Main PID: 24987 (ipmid)
CGroup: /system.slice/phosphor-ipmi-host.service
└─24987 /tmp/ipmid
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X30] for Ethstats Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X32] for Sys Commands
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X002B79], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X02] for I2C
Jan 08 21:20:56 $HOST ipmid[24987]: I2C_WHITELIST_CHECK is disabled, do not populate whitelist
Jan 08 21:20:56 $HOST ipmid[24987]: Registering OEM:[0X00C2CF], Cmd:[0X04] for Manual Zone Control
Jan 08 21:20:56 $HOST systemd[1]: Started Phosphor Inband IPMI.
Jan 08 21:20:56 $HOST ipmid[24987]: Loading whitelist filter
Jan 08 21:20:56 $HOST ipmid[24987]: Set restrictedMode = true
(reverse-i-search)`ipmi': systemctl status phosphor-^Cmi-host
$ ipmitool mc info
Device ID : 32
Device Revision : 1
Firmware Revision : 0.00
IPMI Version : 2.0
Manufacturer ID : 7244
Manufacturer Name : Quanta Computer Inc.
Product ID : 14426 (0x385a)
Product Name : Unknown (0x385A)
Device Available : yes
Provides Device SDRs : yes
Additional Device Support :
Sensor Device
SEL Device
FRU Inventory Device
Chassis Device
Aux Firmware Rev Info :
0x00
0x00
0x00
0x00
```
Change-Id: I372c9433a274bc633a24d213b7a1bc205531e33d
Signed-off-by: Willy Tu <wltu@google.com>
diff --git a/dbus-sdr/sdrutils.cpp b/dbus-sdr/sdrutils.cpp
index 3df0dc1..7de48a8 100644
--- a/dbus-sdr/sdrutils.cpp
+++ b/dbus-sdr/sdrutils.cpp
@@ -40,13 +40,13 @@
*dbus,
"type='signal',member='InterfacesAdded',arg0path='/xyz/openbmc_project/"
"sensors/'",
- [](sdbusplus::message::message& m) { sensorTreePtr.reset(); });
+ [](sdbusplus::message::message&) { sensorTreePtr.reset(); });
static sdbusplus::bus::match::match sensorRemoved(
*dbus,
"type='signal',member='InterfacesRemoved',arg0path='/xyz/"
"openbmc_project/sensors/'",
- [](sdbusplus::message::message& m) { sensorTreePtr.reset(); });
+ [](sdbusplus::message::message&) { sensorTreePtr.reset(); });
if (sensorTreePtr)
{
diff --git a/dbus-sdr/sensorcommands.cpp b/dbus-sdr/sensorcommands.cpp
index 8f177e6..4d35009 100644
--- a/dbus-sdr/sensorcommands.cpp
+++ b/dbus-sdr/sensorcommands.cpp
@@ -115,7 +115,7 @@
*getSdBus(),
"type='signal',member='InterfacesAdded',arg0path='/xyz/openbmc_project/"
"sensors/'",
- [](sdbusplus::message::message& m) {
+ [](sdbusplus::message::message&) {
getSensorTree().clear();
sdrLastAdd = std::chrono::duration_cast<std::chrono::seconds>(
std::chrono::system_clock::now().time_since_epoch())
@@ -126,7 +126,7 @@
*getSdBus(),
"type='signal',member='InterfacesRemoved',arg0path='/xyz/openbmc_project/"
"sensors/'",
- [](sdbusplus::message::message& m) {
+ [](sdbusplus::message::message&) {
getSensorTree().clear();
sdrLastRemove = std::chrono::duration_cast<std::chrono::seconds>(
std::chrono::system_clock::now().time_since_epoch())
@@ -593,11 +593,10 @@
}
ipmi::RspType<> ipmiSetSensorReading(ipmi::Context::ptr ctx,
- uint8_t sensorNumber, uint8_t operation,
+ uint8_t sensorNumber, uint8_t,
uint8_t reading, uint15_t assertOffset,
- bool resvd1, uint15_t deassertOffset,
- bool resvd2, uint8_t eventData1,
- uint8_t eventData2, uint8_t eventData3)
+ bool, uint15_t, bool, uint8_t, uint8_t,
+ uint8_t)
{
std::string connection;
std::string path;
@@ -946,9 +945,9 @@
bool lowerCriticalThreshMask, bool lowerNonRecovThreshMask,
bool upperNonCriticalThreshMask, bool upperCriticalThreshMask,
bool upperNonRecovThreshMask, uint2_t reserved, uint8_t lowerNonCritical,
- uint8_t lowerCritical, uint8_t lowerNonRecoverable,
+ uint8_t lowerCritical, [[maybe_unused]] uint8_t lowerNonRecoverable,
uint8_t upperNonCritical, uint8_t upperCritical,
- uint8_t upperNonRecoverable)
+ [[maybe_unused]] uint8_t upperNonRecoverable)
{
if (sensorNum == reservedSensorNumber || reserved)
{
@@ -1800,7 +1799,7 @@
#ifdef FEATURE_HYBRID_SENSORS
// Construct a type 1 SDR for discrete Sensor typed sensor.
-void constructStaticSensorSdr(ipmi::Context::ptr ctx, uint16_t sensorNum,
+void constructStaticSensorSdr(ipmi::Context::ptr, uint16_t sensorNum,
uint16_t recordID,
ipmi::sensor::IdInfoMap::const_iterator sensor,
get_sdr::SensorDataFullRecord& record)
@@ -2049,7 +2048,7 @@
if (std::find(interfaces.begin(), interfaces.end(),
sensor::sensorInterface) != interfaces.end())
{
- get_sdr::SensorDataFullRecord record = {0};
+ get_sdr::SensorDataFullRecord record = {};
// If the request doesn't read SDR body, construct only header and key
// part to avoid additional DBus transaction.
@@ -2075,7 +2074,7 @@
getSensorEventTypeFromPath(path) !=
static_cast<uint8_t>(SensorEventTypeCodes::threshold))
{
- get_sdr::SensorDataFullRecord record = {0};
+ get_sdr::SensorDataFullRecord record = {};
// If the request doesn't read SDR body, construct only header and key
// part to avoid additional DBus transaction.
@@ -2099,7 +2098,7 @@
if (std::find(interfaces.begin(), interfaces.end(), sensor::vrInterface) !=
interfaces.end())
{
- get_sdr::SensorDataEventRecord record = {0};
+ get_sdr::SensorDataEventRecord record = {};
// If the request doesn't read SDR body, construct only header and key
// part to avoid additional DBus transaction.
diff --git a/dbus-sdr/storagecommands.cpp b/dbus-sdr/storagecommands.cpp
index 35e1bab..6d55211 100644
--- a/dbus-sdr/storagecommands.cpp
+++ b/dbus-sdr/storagecommands.cpp
@@ -230,9 +230,10 @@
}
}
-void replaceCacheFru(const std::shared_ptr<sdbusplus::asio::connection>& bus,
- boost::asio::yield_context& yield,
- const std::optional<std::string>& path = std::nullopt)
+void replaceCacheFru(
+ const std::shared_ptr<sdbusplus::asio::connection>& bus,
+ boost::asio::yield_context& yield,
+ [[maybe_unused]] const std::optional<std::string>& path = std::nullopt)
{
boost::system::error_code ec;
@@ -554,7 +555,7 @@
return ipmi::responseSuccess(fruCache.size(), accessType);
}
-ipmi_ret_t getFruSdrCount(ipmi::Context::ptr ctx, size_t& count)
+ipmi_ret_t getFruSdrCount(ipmi::Context::ptr, size_t& count)
{
count = deviceHashes.size();
return IPMI_CC_OK;
@@ -1084,11 +1085,17 @@
return ipmi::responseUnspecifiedError();
}
-ipmi::RspType<uint16_t> ipmiStorageAddSELEntry(
- uint16_t recordID, uint8_t recordType, uint32_t timestamp,
- uint16_t generatorID, uint8_t evmRev, uint8_t sensorType, uint8_t sensorNum,
- uint8_t eventType, uint8_t eventData1, uint8_t eventData2,
- uint8_t eventData3)
+/*
+Unused arguments
+ uint16_t recordID, uint8_t recordType, uint32_t timestamp,
+ uint16_t generatorID, uint8_t evmRev, uint8_t sensorType, uint8_t sensorNum,
+ uint8_t eventType, uint8_t eventData1, uint8_t eventData2,
+ uint8_t eventData3
+*/
+ipmi::RspType<uint16_t> ipmiStorageAddSELEntry(uint16_t, uint8_t, uint32_t,
+ uint16_t, uint8_t, uint8_t,
+ uint8_t, uint8_t, uint8_t,
+ uint8_t, uint8_t)
{
// Per the IPMI spec, need to cancel any reservation when a SEL entry is
// added
@@ -1098,7 +1105,7 @@
return ipmi::responseSuccess(responseID);
}
-ipmi::RspType<uint8_t> ipmiStorageClearSEL(ipmi::Context::ptr ctx,
+ipmi::RspType<uint8_t> ipmiStorageClearSEL(ipmi::Context::ptr,
uint16_t reservationID,
const std::array<uint8_t, 3>& clr,
uint8_t eraseOperation)
@@ -1189,7 +1196,7 @@
return ipmi::responseSuccess(selTime.tv_sec);
}
-ipmi::RspType<> ipmiStorageSetSELTime(uint32_t selTime)
+ipmi::RspType<> ipmiStorageSetSELTime(uint32_t)
{
// Set SEL Time is not supported
return ipmi::responseInvalidCommand();