Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 15bc9183c9c04d60a8f65db14dd19194d25e8c25
commit15bc9183c9c04d60a8f65db14dd19194d25e8c25[log] [tgz]
authorPatrick Venture <venture@google.com>Mon Dec 03 12:22:50 2018 -0800
committerPatrick Venture <venture@google.com>Tue Dec 11 16:39:50 2018 +0000
tree32b689802e2ac82028baaa90e9577b8aa2a6a027
parent12ca691136435876bf6e06685512c35b6d98c0b1 [diff]
build: fix pam library inclusion and usage

The pam_misc was deliberately included by the
Makefile_am, however, no calls into pam_ were made
from libuserlayer.  Pam calls were made from
usercommand.cpp, in libipmi20.so.  The calls are
part of the primary pam library.

Before:
objdump -t phosphor-host-ipmid/.libs/libipmi20.so\
 |grep "UND"|grep -v "@@"|grep "pam"
0000000000000000 *UND* 0000000000000000 pam_end
0000000000000000 *UND* 0000000000000000 pam_chauthtok
0000000000000000 *UND* 0000000000000000 pam_start

Now:
objdump -t ./.libs/libipmi20.so|grep "UND"|grep pam
0000000000000000 F *UND* 0000000000000000 pam_chauthtok@@LIBPAM_1.0
0000000000000000 F *UND* 0000000000000000 pam_end@@LIBPAM_1.0
0000000000000000 F *UND* 0000000000000000 pam_start@@LIBPAM_1.0

Tested: Searched objects for undefined pam calls
and found the information above.
Change-Id: I44aa570a2087affafba09886fbf17fa9d99abe05
Signed-off-by: Patrick Venture <venture@google.com>
2 files changed
tree: 32b689802e2ac82028baaa90e9577b8aa2a6a027
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. user_channel/
  8. xyz/
  9. .build.sh
  10. .clang-format
  11. .gitignore
  12. .travis.yml
  13. apphandler.cpp
  14. apphandler.hpp
  15. bootstrap.sh
  16. chassishandler.cpp
  17. chassishandler.hpp
  18. configure.ac
  19. dcmihandler.cpp
  20. dcmihandler.hpp
  21. elog-errors.hpp
  22. error-HostEvent.hpp
  23. fruread.hpp
  24. generate_whitelist.sh
  25. globalhandler.cpp
  26. globalhandler.hpp
  27. groupext.cpp
  28. host-cmd-manager.cpp
  29. host-cmd-manager.hpp
  30. host-interface.cpp
  31. host-interface.hpp
  32. host-ipmid-whitelist.conf
  33. ipmi_fru_info_area.cpp
  34. ipmi_fru_info_area.hpp
  35. ipmid.cpp
  36. ipmid.hpp
  37. ipmisensor.cpp
  38. ipmiwhitelist.hpp
  39. LICENSE
  40. MAINTAINERS
  41. Makefile.am
  42. net.cpp
  43. net.hpp
  44. oemrouter.cpp
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. sample.cpp
  49. sample.h
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. transporthandler.hpp
  70. types.hpp
  71. utils.cpp
  72. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.