Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 851acb19d773fe771201968a43b7760c63757b8c
commit851acb19d773fe771201968a43b7760c63757b8c[log] [tgz]
authorJason M. Bills <jason.m.bills@linux.intel.com>Mon Feb 04 14:06:57 2019 -0800
committerVernon Mauery <vernon.mauery@linux.intel.com>Wed Feb 06 21:33:31 2019 +0000
tree58067945be57cdf90db5580621d722701dd58548
parent41ac50530ab0618155d9e8ae3be3a0abd59c24e4 [diff]
Add request data length check to IPMI SEL commands

This changes adds a data length check to all supported IPMI
SEL commands.  This prevents a command from being handled when
too much data is provided in the request.

Tested: Ran Get SEL Info, Reserve SEL, Get SEL Entry, Add SEL Entry
Delete SEL Entry, Clear SEL, Get SEL Time, Set SEL Time, with and
without an extra byte.  Without the extra byte, the commands returned
normally; with the extra byte, a 0xC7 is returned indicating that the
request data length is invalid.

Change-Id: Icdd7db80f1bced3e6efddb5c5655e9f44a4e0e3b
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
1 file changed
tree: 58067945be57cdf90db5580621d722701dd58548
  1. app/
  2. docs/
  3. host-ipmid/
  4. scripts/
  5. softoff/
  6. test/
  7. user_channel/
  8. xyz/
  9. .build.sh
  10. .clang-format
  11. .gitignore
  12. .travis.yml
  13. apphandler.cpp
  14. apphandler.hpp
  15. bootstrap.sh
  16. chassishandler.cpp
  17. chassishandler.hpp
  18. configure.ac
  19. dcmihandler.cpp
  20. dcmihandler.hpp
  21. elog-errors.hpp
  22. error-HostEvent.hpp
  23. fruread.hpp
  24. generate_whitelist.sh
  25. globalhandler.cpp
  26. globalhandler.hpp
  27. groupext.cpp
  28. host-cmd-manager.cpp
  29. host-cmd-manager.hpp
  30. host-interface.cpp
  31. host-interface.hpp
  32. host-ipmid-whitelist.conf
  33. ipmi_fru_info_area.cpp
  34. ipmi_fru_info_area.hpp
  35. ipmid.cpp
  36. ipmid.hpp
  37. ipmisensor.cpp
  38. ipmiwhitelist.hpp
  39. LICENSE
  40. MAINTAINERS
  41. Makefile.am
  42. oemrouter.cpp
  43. read_fru_data.cpp
  44. read_fru_data.hpp
  45. README.md
  46. sample.cpp
  47. sample.h
  48. selutility.cpp
  49. selutility.hpp
  50. sensordatahandler.cpp
  51. sensordatahandler.hpp
  52. sensorhandler.cpp
  53. sensorhandler.hpp
  54. settings.cpp
  55. settings.hpp
  56. storageaddsel.cpp
  57. storageaddsel.hpp
  58. storagehandler.cpp
  59. storagehandler.hpp
  60. sys_info_param.cpp
  61. sys_info_param.hpp
  62. systemintfcmds.cpp
  63. systemintfcmds.hpp
  64. testaddsel.cpp
  65. testit.cpp
  66. transporthandler.cpp
  67. transporthandler.hpp
  68. types.hpp
  69. utils.cpp
  70. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.