Safe overloading with std::equal
Since C++20, there is a safer way to overload std::equal:
template< class InputIt1, class InputIt2 >
constexpr bool equal( InputIt1 first1, InputIt1 last1,
InputIt2 first2, InputIt2 last2 );
Because if they are different lengths, it won't run past on either
side. In theory, they should always be the same length.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1d25331521c1590b5f448f93b657f58f9f06d778
diff --git a/test/cipher.cpp b/test/cipher.cpp
index 09bd479..fa3e020 100644
--- a/test/cipher.cpp
+++ b/test/cipher.cpp
@@ -131,7 +131,7 @@
auto check = algoPtr->verifyIntegrityData(
packet, packetSize - message::parser::RMCP_SESSION_HEADER_SIZE,
- integrityIter);
+ integrityIter, packet.cend());
EXPECT_EQ(true, check);
}
@@ -151,7 +151,7 @@
// Point to the integrity data in the packet
auto integrityIter = packet.cbegin();
- std::advance(integrityIter, packet.size());
+ std::advance(integrityIter, integrity.size());
/*
* Step-2 Invoke the verifyIntegrityData API and validate the response
@@ -168,7 +168,7 @@
// Verify the Integrity Data
auto check = algoPtr->verifyIntegrityData(
packet, packet.size() - message::parser::RMCP_SESSION_HEADER_SIZE,
- integrityIter);
+ integrityIter, packet.cend());
EXPECT_EQ(false, check);
}
@@ -295,7 +295,7 @@
auto check = algoPtr->verifyIntegrityData(
packet, packetSize - message::parser::RMCP_SESSION_HEADER_SIZE,
- integrityIter);
+ integrityIter, packet.cend());
EXPECT_EQ(true, check);
}
@@ -315,7 +315,7 @@
// Point to the integrity data in the packet
auto integrityIter = packet.cbegin();
- std::advance(integrityIter, packet.size());
+ std::advance(integrityIter, integrity.size());
/*
* Step-2 Invoke the verifyIntegrityData API and validate the response
@@ -333,7 +333,7 @@
// Verify the Integrity Data
auto check = algoPtr->verifyIntegrityData(
packet, packet.size() - message::parser::RMCP_SESSION_HEADER_SIZE,
- integrityIter);
+ integrityIter, packet.cend());
EXPECT_EQ(false, check);
}