Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 1bb0d387cd238a1d4b8c38c474433ccaada47a22
commit1bb0d387cd238a1d4b8c38c474433ccaada47a22[log] [tgz]
authorDeepak Kodihalli <dkodihal@in.ibm.com>Sat Aug 12 02:01:27 2017 -0500
committerPatrick Williams <patrick@stwcx.xyz>Tue Aug 15 19:29:25 2017 +0000
tree2034d96ff380e7f20f5405fad129fb1cddd54149
parent8b26d353da78858d92c2e0fa814a79e5a6dd29e7 [diff]
Refactor set sensor handling code

A summary of the changes:

- Do not generate per sensor type code to update d-bus objects
  corresponding to sensors. Function to update d-bus objects based on
  standard sensor event types, such as assertion, event data, are now
  generic functions - the need not be generated per sensor or per sensor
  type.
- There's a special case where the assertion is treated as a reading
  (i.e read the entire assertion field as-is). In this case, code needs
  to be generated per sensor because the type of the  mapped d-bus
  property can vary. In this case have a generic template function, and
  generate minimal code like so:
  inline ipmi_ret_t readingAssertion(const SetSensorReadingReq& cmdData,
                                     const Info& sensorInfo)
  {
      // Corresponding d-bus property is uint32_t
      return set::readingAssertion<uint32_t>(cmdData, sensorInfo);
  }
- Make sensor-example.yaml succinct.
- Make the code in writesensor.mako.cpp more pythonic.

Change-Id: I84415ca6e3f756bbb51a90e290539eb086a7f78b
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
6 files changed
tree: 2034d96ff380e7f20f5405fad129fb1cddd54149
  1. docs/
  2. host-ipmid/
  3. scripts/
  4. softoff/
  5. test/
  6. xyz/
  7. .build.sh
  8. .gitignore
  9. .travis.yml
  10. apphandler.cpp
  11. apphandler.h
  12. bootstrap.sh
  13. chassishandler.cpp
  14. chassishandler.h
  15. configure.ac
  16. dcmihandler.cpp
  17. dcmihandler.hpp
  18. elog-errors.hpp
  19. error-HostEvent.hpp
  20. fruread.hpp
  21. generate_whitelist.sh
  22. globalhandler.cpp
  23. globalhandler.h
  24. groupext.cpp
  25. host-cmd-manager.cpp
  26. host-cmd-manager.hpp
  27. host-interface.cpp
  28. host-interface.hpp
  29. host-ipmid-whitelist.conf
  30. ipmi_fru_info_area.cpp
  31. ipmi_fru_info_area.hpp
  32. ipmid.cpp
  33. ipmid.hpp
  34. ipmisensor.cpp
  35. ipmiwhitelist.hpp
  36. LICENSE
  37. Makefile.am
  38. read_fru_data.cpp
  39. read_fru_data.hpp
  40. README.md
  41. sample.cpp
  42. sample.h
  43. selutility.cpp
  44. selutility.hpp
  45. sensordatahandler.cpp
  46. sensordatahandler.hpp
  47. sensorhandler.cpp
  48. sensorhandler.h
  49. settings.cpp
  50. settings.hpp
  51. storageaddsel.cpp
  52. storageaddsel.h
  53. storagehandler.cpp
  54. storagehandler.h
  55. systemintfcmds.cpp
  56. systemintfcmds.h
  57. testaddsel.cpp
  58. testit.cpp
  59. timer.cpp
  60. timer.hpp
  61. transporthandler.cpp
  62. transporthandler.hpp
  63. types.hpp
  64. utils.cpp
  65. utils.hpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To full clean the repository again run ./bootstrap.sh clean.