commit 1c2d36d3bc641afb01558562cbe4673a01815559
author George Liu <liuxiwei@ieisystem.com> Thu Dec 05 15:52:16 2024 +0800
committer George Liu <liuxiwei@ieisystem.com> Mon Mar 03 09:54:41 2025 +0800
tree ccf28e45a788447708f79851420d26b422c0065a
parent befca3c3f33d5ff63c8e2cf6674487d325a16f6b

apphandler: remove IPMI_CMD command

The IPMI_CMD declared in apphandler.hpp is redundant because these
commands are already declared in api-types.hpp, so this commit
removes all IPMI_CMD in apphandler.hpp

Change-Id: I7c0e38ee00c906e2c1495d05fb66b99b4db62a11
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

apphandler.hpp

diff --git a/apphandler.hpp b/apphandler.hpp
index 4f03121..56dd0f8 100644
--- a/apphandler.hpp
+++ b/apphandler.hpp
@@ -2,27 +2,6 @@
 
 #include <stdint.h>
 
-// IPMI commands for App net functions.
-enum ipmi_netfn_app_cmds
-{
-    // Get capability bits
-    IPMI_CMD_GET_DEVICE_ID = 0x01,
-    IPMI_CMD_GET_SELF_TEST_RESULTS = 0x04,
-    IPMI_CMD_SET_ACPI = 0x06,
-    IPMI_CMD_GET_ACPI = 0x07,
-    IPMI_CMD_GET_DEVICE_GUID = 0x08,
-    IPMI_CMD_RESET_WD = 0x22,
-    IPMI_CMD_SET_WD = 0x24,
-    IPMI_CMD_GET_WD = 0x25,
-    IPMI_CMD_GET_CAP_BIT = 0x36,
-    IPMI_CMD_GET_SYS_GUID = 0x37,
-    IPMI_CMD_SET_CHAN_ACCESS = 0x40,
-    IPMI_CMD_GET_CHANNEL_ACCESS = 0x41,
-    IPMI_CMD_GET_CHAN_INFO = 0x42,
-    IPMI_CMD_SET_SYSTEM_INFO = 0x58,
-    IPMI_CMD_GET_SYSTEM_INFO = 0x59,
-};
-
 enum ipmi_app_sysinfo_params
 {
     IPMI_SYSINFO_SET_STATE = 0x00,

user_channel/channel_mgmt.cpp

diff --git a/user_channel/channel_mgmt.cpp b/user_channel/channel_mgmt.cpp
index ed123ad..31fdba0 100644
--- a/user_channel/channel_mgmt.cpp
+++ b/user_channel/channel_mgmt.cpp
@@ -16,7 +16,6 @@
 
 #include "channel_mgmt.hpp"
 
-#include "apphandler.hpp"
 #include "user_layer.hpp"
 
 #include <ifaddrs.h>

user_channel/channelcommands.cpp

diff --git a/user_channel/channelcommands.cpp b/user_channel/channelcommands.cpp
index f98a5e7..cb4da6b 100644
--- a/user_channel/channelcommands.cpp
+++ b/user_channel/channelcommands.cpp
@@ -14,7 +14,6 @@
 // limitations under the License.
 */
 
-#include "apphandler.hpp"
 #include "channel_layer.hpp"
 
 #include <ipmid/api.hpp>

user_channel/user_mgmt.cpp

diff --git a/user_channel/user_mgmt.cpp b/user_channel/user_mgmt.cpp
index 81e409e..3d9a82f 100644
--- a/user_channel/user_mgmt.cpp
+++ b/user_channel/user_mgmt.cpp
@@ -15,7 +15,6 @@
 */
 #include "user_mgmt.hpp"
 
-#include "apphandler.hpp"
 #include "channel_layer.hpp"
 #include "channel_mgmt.hpp"
 

user_channel/usercommands.cpp

diff --git a/user_channel/usercommands.cpp b/user_channel/usercommands.cpp
index 4a3e24a..3e1b3ca 100644
--- a/user_channel/usercommands.cpp
+++ b/user_channel/usercommands.cpp
@@ -16,7 +16,6 @@
 
 #include "usercommands.hpp"
 
-#include "apphandler.hpp"
 #include "channel_layer.hpp"
 #include "user_layer.hpp"