Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-host-ipmid / 1d8579c60732395bd856926c1d6edb99aaf9c327
commit1d8579c60732395bd856926c1d6edb99aaf9c327[log] [tgz]
authorsrikanta mondal <srikantax.mondal@intel.com>Wed Apr 15 17:13:25 2020 +0000
committerVernon Mauery <vernon.mauery@linux.intel.com>Mon May 11 22:40:08 2020 +0000
treef1bbb1ba5b121b3260ce82ebbd7a1a4f176230a6
parente86e7855ff539092b8298d49ba2df4c349418452 [diff]
transporthandler:Fix get lan config param 22 & 23

Issue: get Lan configuration command for ciphersuite are getting
       executed successfully for session less channel.

Fix: get lan config - provided fix by returning error for session
     less channel

Test:
Before:
Command: ipmitool raw 0x0c 0x02 0x7 0x16 0x00 0x00 // GetLan cipher support
Response: 11 01    // Success
Command: ipmitool raw 0x0c 0x02 0x7 0x17 0x00 0x00 // Getlan cipher entry
Response: 11 00 11   // Success

After:
Command: ipmitool raw 0x0c 0x02 0x7 0x16 0x00 0x00 // GetLan cipher support
Response: Unable to send RAW command (channel=0x0 netfn=0xc
          lun=0x0 cmd=0x2 rsp=0xcc): Invalid data field in request
Command: ipmitool raw 0x0c 0x02 0x7 0x17 0x00 0x00 // Getlan cipher entry
Response: Unable to send RAW command (channel=0x0 netfn=0xc
          lun=0x0 cmd=0x2 rsp=0xcc): Invalid data field in request

Before and After: Session based LAN channel 3:
Command: ipmitool raw 0x0c 0x02 0x3 0x16 0x00 0x00 // GetLan cipher support
Response: 11 01    // Success
Command: ipmitool raw 0x0c 0x02 0x3 0x17 0x00 0x00 // Getlan cipher entry
Response: 11 00 11   // Success

Signed-off-by: srikanta mondal <srikantax.mondal@intel.com>
Change-Id: I00d4f85c7461821e25e77efd885a08b859d421ec
1 file changed
tree: f1bbb1ba5b121b3260ce82ebbd7a1a4f176230a6
  1. app/
  2. docs/
  3. include/
  4. libipmid/
  5. libipmid-host/
  6. scripts/
  7. softoff/
  8. test/
  9. user_channel/
  10. xyz/
  11. .build.sh
  12. .clang-format
  13. .gitignore
  14. .travis.yml
  15. apphandler.cpp
  16. apphandler.hpp
  17. bootstrap.sh
  18. chassishandler.cpp
  19. chassishandler.hpp
  20. configure.ac
  21. dcmihandler.cpp
  22. dcmihandler.hpp
  23. elog-errors.hpp
  24. entity_map_json.cpp
  25. entity_map_json.hpp
  26. error-HostEvent.hpp
  27. fruread.hpp
  28. generate_whitelist.sh
  29. globalhandler.cpp
  30. globalhandler.hpp
  31. groupext.cpp
  32. host-cmd-manager.cpp
  33. host-cmd-manager.hpp
  34. host-interface.cpp
  35. host-interface.hpp
  36. host-ipmid-whitelist.conf
  37. ipmi_fru_info_area.cpp
  38. ipmi_fru_info_area.hpp
  39. ipmid-new.cpp
  40. ipmisensor.cpp
  41. ipmiwhitelist.hpp
  42. LICENSE
  43. MAINTAINERS
  44. Makefile.am
  45. read_fru_data.cpp
  46. read_fru_data.hpp
  47. README.md
  48. sample.cpp
  49. sample.h
  50. selutility.cpp
  51. selutility.hpp
  52. sensordatahandler.cpp
  53. sensordatahandler.hpp
  54. sensorhandler.cpp
  55. sensorhandler.hpp
  56. settings.cpp
  57. settings.hpp
  58. storageaddsel.cpp
  59. storageaddsel.hpp
  60. storagehandler.cpp
  61. storagehandler.hpp
  62. sys_info_param.cpp
  63. sys_info_param.hpp
  64. systemintfcmds.cpp
  65. systemintfcmds.hpp
  66. testaddsel.cpp
  67. testit.cpp
  68. transporthandler.cpp
  69. whitelist-filter.cpp
README.md

To build this package, do the following steps:

1. ./bootstrap.sh
2. ./configure ${CONFIGURE_FLAGS}
3. make

To clean the repository run ./bootstrap.sh clean.